Bug 114383

Summary: Cleanup local variables in Editor::markAndReplaceFor
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: New BugsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, enrica, jiapu.mail, mifenton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 114337    
Attachments:
Description Flags
Cleanup enrica: review+

Ryosuke Niwa
Reported 2013-04-10 14:21:55 PDT
Cleanup local variables in Editor::markAndReplaceFor
Attachments
Cleanup (7.25 KB, patch)
2013-04-10 14:24 PDT, Ryosuke Niwa 		enrica: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2013-04-10 14:24:59 PDT
Created attachment 197406 [details] Cleanup
Enrica Casucci
Comment 2 2013-04-10 17:47:33 PDT
Comment on attachment 197406 [details] Cleanup I don't think you can remove the #if USE_AUTOCORRECTION_PANEL, because it is compiled out for iOS. Could you please verify?
Enrica Casucci
Comment 3 2013-04-10 17:50:19 PDT
Comment on attachment 197406 [details] Cleanup Looks good.
Ryosuke Niwa
Comment 4 2013-04-10 18:25:53 PDT
Committed r148163: <http://trac.webkit.org/changeset/148163>
Note You need to log in before you can comment on or make changes to this bug.