WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
114383
Cleanup local variables in Editor::markAndReplaceFor
https://bugs.webkit.org/show_bug.cgi?id=114383
Summary
Cleanup local variables in Editor::markAndReplaceFor
Ryosuke Niwa
Reported
2013-04-10 14:21:55 PDT
Cleanup local variables in Editor::markAndReplaceFor
Attachments
Cleanup
(7.25 KB, patch)
2013-04-10 14:24 PDT
,
Ryosuke Niwa
enrica
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1
2013-04-10 14:24:59 PDT
Created
attachment 197406
[details]
Cleanup
Enrica Casucci
Comment 2
2013-04-10 17:47:33 PDT
Comment on
attachment 197406
[details]
Cleanup I don't think you can remove the #if USE_AUTOCORRECTION_PANEL, because it is compiled out for iOS. Could you please verify?
Enrica Casucci
Comment 3
2013-04-10 17:50:19 PDT
Comment on
attachment 197406
[details]
Cleanup Looks good.
Ryosuke Niwa
Comment 4
2013-04-10 18:25:53 PDT
Committed
r148163
: <
http://trac.webkit.org/changeset/148163
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug