Bug 114344

Summary: Refactor Editor::markAndReplaceFor before fixing autocorrection bugs
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, enrica, jiapu.mail, mifenton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 114337    
Attachments:
Description Flags
Cleanup
none
More cleanups enrica: review+

Ryosuke Niwa
Reported 2013-04-10 02:18:33 PDT
Refactor Editor::markAndReplaceFor before fixing autocorrection bugs
Attachments
Cleanup (14.27 KB, patch)
2013-04-10 02:23 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
More cleanups (16.06 KB, patch)
2013-04-10 02:32 PDT, Ryosuke Niwa 		enrica: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2013-04-10 02:23:46 PDT
Created attachment 197227 [details] Cleanup
Ryosuke Niwa
Comment 2 2013-04-10 02:32:56 PDT
Created attachment 197230 [details] More cleanups
Enrica Casucci
Comment 3 2013-04-10 11:20:04 PDT
Comment on attachment 197230 [details] More cleanups View in context: https://bugs.webkit.org/attachment.cgi?id=197230&action=review Looks ok to me. just few nits in the change log. > Source/WebCore/ChangeLog:8 > + This patch refactors Editor::markAndReplaceFor so that we can start fixing bugs in a sane staet. Typo: state. > Source/WebCore/ChangeLog:12 > + In particular, shouldMarkSpelling used to be set false when shouldShowCorrectionPanel was true to false > Source/WebCore/ChangeLog:14 > + since shouldMarkSpelling was only referred once after the assignment. typo referenced. > Source/WebCore/editing/Editor.cpp:2265 > + bool existingMarkersPermitReplacement = m_alternativeTextController->processMarkersOnTextToBeReplacedByResult(&results[i], rangeToReplace.get(), replacedString); Can this be const as well?
Ryosuke Niwa
Comment 4 2013-04-10 11:26:06 PDT
Thanks for the review! Will land after fixing these nits.
Ryosuke Niwa
Comment 5 2013-04-10 12:15:25 PDT
Committed r148124: <http://trac.webkit.org/changeset/148124>
Note You need to log in before you can comment on or make changes to this bug.