Bug 114336

Summary:

Removed bitrotted TimeoutChecker code

Product:

WebKit

Reporter:

Geoffrey Garen <ggaren>

Component:

New Bugs

Assignee:

Geoffrey Garen <ggaren>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

alecflett, commit-queue, dgrogan, gyuyoung.kim, jsbell, mark.lam, mifenton, rakuco, rwlbuis, tonikitoo

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	ap: review+

Description Geoffrey Garen 2013-04-09 23:18:04 PDT

Removed bitrotted TimeoutChecker code

Comment 1 Geoffrey Garen 2013-04-09 23:21:35 PDT

Created attachment 197214 [details]
Patch

Comment 2 EFL EWS Bot 2013-04-10 02:32:05 PDT

Comment on attachment 197214 [details]
Patch

Attachment 197214 [details] did not pass efl-ews (efl):
Output: http://webkit-commit-queue.appspot.com/results/17710082

Comment 3 EFL EWS Bot 2013-04-10 03:58:18 PDT

Comment on attachment 197214 [details]
Patch

Attachment 197214 [details] did not pass efl-ews (efl):
Output: http://webkit-commit-queue.appspot.com/results/17604070

Comment 4 Geoffrey Garen 2013-04-10 08:49:33 PDT

Created attachment 197273 [details]
Patch

Comment 5 Alexey Proskuryakov 2013-04-10 09:47:15 PDT

Comment on attachment 197273 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=197273&action=review

Oh, this smell of bitrot in the morning...

> Source/JavaScriptCore/ChangeLog:31
> +        * dfg/DFGGPRInfo.h:
> +        (GPRInfo):
> +        * jit/JIT.cpp:
> +        (JSC):
> +        * jit/JIT.h:
> +        (JIT):
> +        * jit/JITStubs.cpp:
> +        (JSC):

This is so unhelpful. Personally, I think that even file lists are unnecessary in ChangeLogs for patches like this, but listing namespaces is just wrong.

Comment 6 Geoffrey Garen 2013-04-10 11:50:14 PDT

Committed r148119: <http://trac.webkit.org/changeset/148119>