Bug 114334

Summary: WKPageCopySessionState needs to provide more context to the filter callback
Product: WebKit Reporter: Mark Rowe (bdash) <mrowe>
Component: WebKit2Assignee: Mark Rowe (bdash) <mrowe>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch v1 darin: review+

Description Mark Rowe (bdash) 2013-04-09 23:00:06 PDT 
WKPageCopySessionState passes the filter callback the original, pre-redirect URL of each entry in the back / forward list.  The filter callback should be passed more context, at least the actual URL of the back / forward list entries.

<rdar://problem/13617104>
Comment 1 Mark Rowe (bdash) 2013-04-09 23:01:06 PDT 
Created attachment 197212 [details]
Patch v1
Comment 2 WebKit Commit Bot 2013-04-10 10:53:35 PDT 
Attachment 197212 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit2/UIProcess/API/C/WKPage.cpp', u'Source/WebKit2/UIProcess/API/C/WKPage.h', u'Source/WebKit2/UIProcess/cf/WebBackForwardListCF.cpp']" exit_code: 1
Source/WebKit2/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Mark Rowe (bdash) 2013-04-10 11:13:31 PDT 
Landed in r148112.