Summary: | ContentSecurityPolicy::logToConsole should include line/column number and source location | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||||||
Component: | Web Inspector | Assignee: | Devin Rousso <hi> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | bfulgham, commit-queue, dbates, ews-watchlist, hi, inspector-bugzilla-changes, joepeck, mkwst, timothy, webkit-bug-importer, wilander | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Joseph Pecoraro
2013-04-09 16:14:13 PDT
Created attachment 265985 [details]
test case
Dan: Did you do anything to address this in your various CSP changes? Otherwise, John should try to attack this soon. (In reply to comment #3) > Dan: Did you do anything to address this in your various CSP changes? No. Re-assigning to Daniel Bates since he is refactoring this code any way. TextPostition is used above this which has an m_line and m_column. Might be easy. Created attachment 362044 [details]
Patch
Comment on attachment 362044 [details]
Patch
I think this needs a test, otherwise I'd have done the same thing myself! There is a test case attached to the bugzilla bug.
Comment on attachment 362044 [details]
Patch
I think this patch will improve some violations, but I don’t think this will improve much. The problem is that we may not have source information at all. Last I recall source information is only available during script execution and at parse time. Subresource loads tend to be scheduled outside these Windows. Prove me wrong, please!
I think I have a partial, likely outdated, patch for this with a boat load of tests. That’s why this bug is assigned to me :) unassigning and please take take it! Why do I have a boat load tests: I seem to recall under testing of log messsages. I will post once I get to my computer and assuming my memory is correct :D. Worst case, I have a boat load of tests for some other bug. Definitely have a boat load of something. Created attachment 364694 [details]
Patch
Comment on attachment 364694 [details] Patch Clearing flags on attachment: 364694 Committed r244563: <https://trac.webkit.org/changeset/244563> All reviewed patches have been landed. Closing bug. |