Bug 114315

Summary: ScriptExecutionContext log exception should include a column number
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: graouts, joepeck, oliver, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
[PATCH] Proposed Fix oliver: review+, joepeck: commit-queue-

Joseph Pecoraro
Reported 2013-04-09 16:02:22 PDT
ScriptExecutionContext has logExceptionToConsole which may send error ConsoleMessages to the inspector. In order to jump to the proper place in source code the inspector needs both the line number and column number. Examples would be JavaScript runtime exceptions.
Attachments
[PATCH] Proposed Fix (35.21 KB, patch)
2013-04-24 20:20 PDT, Joseph Pecoraro 		oliver: review+
joepeck: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2013-04-09 16:03:27 PDT
<rdar://problem/13614420>
Joseph Pecoraro
Comment 2 2013-04-09 16:04:54 PDT
This should also cover ScriptExecutionContext::reportException.
Radar WebKit Bug Importer
Comment 3 2013-04-09 16:05:14 PDT
<rdar://problem/13614454>
Joseph Pecoraro
Comment 4 2013-04-24 20:20:19 PDT
Created attachment 199610 [details] [PATCH] Proposed Fix Likely requires a patch on another bug and needs to be rebased in order to build. I'll work on making that happen so the bots can build as expected. The change however would remain essentially the same.
Joseph Pecoraro
Comment 5 2013-04-25 12:31:11 PDT
Landed r149131: <http://trac.webkit.org/changeset/149131>
Note You need to log in before you can comment on or make changes to this bug.