Summary: | JSCustomXPathNSResolver::lookupNamespaceURI Console Message should render with a column number | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||||||
Component: | Web Inspector | Assignee: | John Wilander <wilander> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | ap, bburg, bfulgham, commit-queue, dpino, joepeck, timothy, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | EasyFix, GoodFirstBug, InRadar | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Joseph Pecoraro
2013-04-09 15:55:40 PDT
I reproduced the bug by opening LayoutTests/fast/xpath/nsresolver-bad-object.xhtml in MiniBrowser and opening the WebInspector console. There's a link to the source file, column number, and line number, although console->addMessage is logged without these values. Maybe this information is filled up somewhere by the inspector in case it was not provided? Or maybe I'm not reproducing this bug correctly :) This appears to work in shipping Safari now. Created attachment 265983 [details]
test case
This now works properly. This bug is probably fixed, but there is still a FIXME to fix it in Source/WebCore/bindings/js/JSCustomXPathNSResolver.cpp. I'll test and remove if it appears fixed. Reopening so we can remove the FIXME. Created attachment 268223 [details]
[PATCH] Proposed Fix
Yep, works even when the JS code is minified. Remove the FIXME.
Comment on attachment 268223 [details]
[PATCH] Proposed Fix
r=me. Do it!
Comment on attachment 268223 [details] [PATCH] Proposed Fix Rejecting attachment 268223 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 268223, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit /Volumes/Data/EWS/WebKit/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://webkit-queues.webkit.org/results/649861 Created attachment 268240 [details]
[PATCH] For Landing
Comment on attachment 268240 [details] [PATCH] For Landing Clearing flags on attachment: 268240 Committed r194564: <http://trac.webkit.org/changeset/194564> All reviewed patches have been landed. Closing bug. |