Summary: | [GTK][AC] Clean up code related with the children management stuff for clutter based AC | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | ChangSeok Oh <kevin.cs.oh> | ||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | commit-queue, gustavo | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Linux | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 105699 | ||||||||
Attachments: |
|
Description
ChangSeok Oh
2013-04-09 03:02:08 PDT
Created attachment 198904 [details]
Patch
Comment on attachment 198904 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=198904&action=review > Source/WebCore/platform/graphics/clutter/GraphicsLayerClutter.cpp:270 > - graphicsLayerActorRemoveAll(GRAPHICS_LAYER_ACTOR(actor.get())); > + clutter_actor_remove_all_children(actor.get()); I would prefer if you split this in two patches, one dealing with cleaning up the children management stuff and one cleaning up scrolling/translation. Created attachment 199628 [details]
Patch
(In reply to comment #2) > (From update of attachment 198904 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=198904&action=review > > > Source/WebCore/platform/graphics/clutter/GraphicsLayerClutter.cpp:270 > > - graphicsLayerActorRemoveAll(GRAPHICS_LAYER_ACTOR(actor.get())); > > + clutter_actor_remove_all_children(actor.get()); > > I would prefer if you split this in two patches, one dealing with cleaning up the children management stuff and one cleaning up scrolling/translation. Yup. I opened a new bug to deal with cleaning up scroll/translation here. https://bugs.webkit.org/show_bug.cgi?id=115160 Comment on attachment 199628 [details] Patch Clearing flags on attachment: 199628 Committed r149281: <http://trac.webkit.org/changeset/149281> All reviewed patches have been landed. Closing bug. |