Bug 114256 – [Qt][Wk2] Most of layout tests contain improper line breaks.

• Component: Tools / Tests
• Status: RESOLVED DUPLICATE

[Ádám Kallai]

The test results contain line break improperly.

 * animations/cross-fade-border-image-source.html's diff:

--- /home/kadam/webkit/Webkittmp/layout-test-results/animations/cross-fade-border-image-source-expected.txt
+++ /home/kadam/webkit/Webkittmp/layout-test-results/animations/cross-fade-border-image-source-actual.txt
@@ -1,18 +1,63 @@
-layer at (0,0) size 800x600
-  RenderView at (0,0) size 800x600
-layer at (0,0) size 800x600
-  RenderBlock {HTML} at (0,0) size 800x600
-    RenderBody {BODY} at (8,8) size 784x584
-      RenderBlock {DIV} at (0,0) size 784x57
-        RenderText {#text} at (0,0) size 562x19
-          text run at (0,0) width 562: "PASS - \"borderImageSource\" property for \"box\" element at 2.5s saw something close to: 0.5"
-        RenderBR {BR} at (562,15) size 0x0
-        RenderText {#text} at (0,19) size 683x19
-          text run at (0,19) width 683: "PASS - \"borderImageSource\" property for \"box\" and \"boxStatic\" elements at 2.5s are close enough to each other"
-        RenderBR {BR} at (683,34) size 0x0
-        RenderText {#text} at (0,38) size 745x19
-          text run at (0,38) width 745: "PASS - \"borderImageSource\" property for \"boxShorthand\" and \"boxStatic\" elements at 2.5s are close enough to each other"
-        RenderBR {BR} at (745,53) size 0x0
+layer at (0,0) size 206x928
+  RenderView at (0,0) size 0x0
+layer at (0,0) size 0x928
+  RenderBlock {HTML} at (0,0) size 0x928
+    RenderBody {BODY} at (8,8) size 0x912
+      RenderBlock {DIV} at (0,0) size 0x912
+        RenderText {#text} at (0,0) size 131x266
+          text run at (0,0) width 38: "PASS"
+          text run at (0,19) width 6: "-"
+          text run at (0,38) width 131: "\"borderImageSource\""
+          text run at (0,57) width 52: "property"
+          text run at (0,76) width 17: "for"
+          text run at (0,95) width 33: "\"box\""
+          text run at (0,114) width 46: "element"
+          text run at (0,133) width 11: "at"
+          text run at (0,152) width 26: "2.5s"
+          text run at (0,171) width 24: "saw"
+          text run at (0,190) width 60: "something"
+          text run at (0,209) width 31: "close"
+          text run at (0,228) width 15: "to:"
+          text run at (0,247) width 20: "0.5"
+        RenderBR {BR} at (0,0) size 0x0
+        RenderText {#text} at (0,266) size 131x323
+          text run at (0,266) width 38: "PASS"
+          text run at (0,285) width 6: "-"
+          text run at (0,304) width 131: "\"borderImageSource\""
+          text run at (0,323) width 52: "property"
+          text run at (0,342) width 17: "for"
+          text run at (0,361) width 33: "\"box\""
+          text run at (0,380) width 22: "and"
+          text run at (0,399) width 67: "\"boxStatic\""
+          text run at (0,418) width 52: "elements"
+          text run at (0,437) width 11: "at"
+          text run at (0,456) width 26: "2.5s"
+          text run at (0,475) width 19: "are"
+          text run at (0,494) width 31: "close"
+          text run at (0,513) width 43: "enough"
+          text run at (0,532) width 12: "to"
+          text run at (0,551) width 28: "each"
+          text run at (0,570) width 31: "other"
+        RenderBR {BR} at (0,0) size 0x0
+        RenderText {#text} at (0,589) size 131x323
+          text run at (0,589) width 38: "PASS"
+          text run at (0,608) width 6: "-"
+          text run at (0,627) width 131: "\"borderImageSource\""
+          text run at (0,646) width 52: "property"
+          text run at (0,665) width 17: "for"
+          text run at (0,684) width 95: "\"boxShorthand\""
+          text run at (0,703) width 22: "and"
+          text run at (0,722) width 67: "\"boxStatic\""
+          text run at (0,741) width 52: "elements"
+          text run at (0,760) width 11: "at"
+          text run at (0,779) width 26: "2.5s"
+          text run at (0,798) width 19: "are"
+          text run at (0,817) width 31: "close"
+          text run at (0,836) width 43: "enough"
+          text run at (0,855) width 12: "to"
+          text run at (0,874) width 28: "each"
+          text run at (0,893) width 31: "other"
+        RenderBR {BR} at (0,0) size 0x0
 layer at (100,100) size 106x106
   RenderBlock (positioned) {DIV} at (100,100) size 106x106 [bgcolor=#008000] [border: (3px none #000000)]
 layer at (100,250) size 106x106

 * animations/additive-transform-animations.html
 * animations/cross-fade-background-image.html
 * animations/cross-fade-list-style-image.html
 * animations/cross-fade-webkit-mask-box-image.html
 * animations/cross-fade-webkit-mask-image.html
 * animations/missing-values-first-keyframe.html
 * animations/missing-values-last-keyframe.html
 * animations/opacity-transform-animation.html
 * animations/state-at-end-event.html
 * animations/suspend-transform-animation.html

[Ádám Kallai]

I complete my previous statement. Not only animations tests are failing. There are a lot of other layout test fail. It seems if there are some texts in the layout test result, then it will be split by line break.

[Glenn Adams]

You might want to check if this regression was introduced by [1].

[1] http://trac.webkit.org/changeset/147588

[Ádám Kallai]

Thanks. I checked it. It didn't cause problem.

[Ádám Kallai]

I have investigated this problem with Andras Becsi. Firstly I was looking for the problem in the qtbase, but i didn't locate source of the problem. It seems the problem is in another part of Qt. It is obscure. This problem causes most of the layout test failures out of 14262 (fail). I started to investigate in qtdeclarative.

[Ádám Kallai]

Created attachment 203559 [details]
bisect log of qtbase

[Andras Becsi]

These issues were caused by a change in qtdeclarative and were fixed in bug 117203.

Thanks Adam for pinning down the source.

*** This bug has been marked as a duplicate of bug 117203 ***