Bug 11424

Summary:

Cleanup rendering code

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
Patch	mitz: review-
updated patch	mitz: review+

Sam Weinig

Reported 2006-10-26 11:10:58 PDT

Just some fall cleaning.

Attachments
Patch (43.69 KB, patch) 2006-10-26 11:13 PDT, Sam Weinig	mitz: review-	Details Formatted Diff Diff
updated patch (44.28 KB, patch) 2006-10-26 12:59 PDT, Sam Weinig	mitz: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Sam Weinig

Comment 1 2006-10-26 11:13:40 PDT

Created attachment 11226 [details] Patch Code cleanup of files in Rendering directory not starting with Rendering*

Sam Weinig

Comment 2 2006-10-26 11:36:14 PDT

(In reply to comment #1) > Created an attachment (id=11226) [edit] > Patch > > Code cleanup of files in Rendering directory not starting with Rendering* > Mitz points out that it should be files "not starting with Render*". I apologize for any hardships this error may of caused.

mitz

Comment 3 2006-10-26 12:15:30 PDT

Comment on attachment 11226 [details] Patch r- only because the first 'false' in + : InlineBox(obj, 0, y, width, height, baseline, firstLine, false, false, false, 0, 0, parent) should be 'true' (corresponding to m_constructed = true).

Sam Weinig

Comment 4 2006-10-26 12:59:26 PDT

Created attachment 11227 [details] updated patch Updated to fix issue pointed out by mitz.

mitz

Comment 5 2006-10-26 13:04:29 PDT

Comment on attachment 11227 [details] updated patch r=me

Sam Weinig

Comment 6 2006-10-26 13:38:13 PDT

Landed in r17338.

Note You need to log in before you can comment on or make changes to this bug.