Bug 11424 - Cleanup rendering code
Summary: Cleanup rendering code
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2006-10-26 11:10 PDT by Sam Weinig
Modified: 2006-10-26 13:38 PDT (History)
0 users

See Also:

Patch (43.69 KB, patch)
2006-10-26 11:13 PDT, Sam Weinig
mitz: review-
Details | Formatted Diff | Diff
updated patch (44.28 KB, patch)
2006-10-26 12:59 PDT, Sam Weinig
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2006-10-26 11:10:58 PDT
Just some fall cleaning.
Comment 1 Sam Weinig 2006-10-26 11:13:40 PDT
Created attachment 11226 [details]

Code cleanup of files in Rendering directory not starting with Rendering*
Comment 2 Sam Weinig 2006-10-26 11:36:14 PDT
(In reply to comment #1)
> Created an attachment (id=11226) [edit]
> Patch
> Code cleanup of files in Rendering directory not starting with Rendering*

Mitz points out that it should be files "not starting with Render*".  I apologize for any hardships this error may of caused.
Comment 3 mitz 2006-10-26 12:15:30 PDT
Comment on attachment 11226 [details]

r- only because the first 'false' in
+        : InlineBox(obj, 0, y, width, height, baseline, firstLine, false, false, false, 0, 0, parent)

should be 'true' (corresponding to m_constructed = true).
Comment 4 Sam Weinig 2006-10-26 12:59:26 PDT
Created attachment 11227 [details]
updated patch

Updated to fix issue pointed out by mitz.
Comment 5 mitz 2006-10-26 13:04:29 PDT
Comment on attachment 11227 [details]
updated patch

Comment 6 Sam Weinig 2006-10-26 13:38:13 PDT
Landed in r17338.