Bug 114221

Summary: Remove chromium EWS support, and fix broken test.
Product: WebKit Reporter: Glenn Adams <glenn>
Component: Tools / TestsAssignee: Glenn Adams <glenn>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, benjamin, commit-queue, dpranke, eric, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Glenn Adams
Reported 2013-04-08 16:34:03 PDT
Remove AbstractChromiumEWS class and subclasses (and related unit tests). Also fix broken unit test: webkitpy.tool.commands.earlywarningsystem_unittest.EarlyWarningSystemTest.test_ewses which had a misspelled class name and a non-conforming test entry point name.
Attachments
Patch (3.72 KB, patch)
2013-04-08 16:41 PDT, Glenn Adams 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Glenn Adams
Comment 1 2013-04-08 16:41:23 PDT
Created attachment 196969 [details] Patch
Ryosuke Niwa
Comment 2 2013-04-08 17:19:08 PDT
Comment on attachment 196969 [details] Patch Oh oops, sorry wrong patch.
WebKit Commit Bot
Comment 3 2013-04-08 17:21:04 PDT
Comment on attachment 196969 [details] Patch Clearing flags on attachment: 196969 Committed r147966: <http://trac.webkit.org/changeset/147966>
WebKit Commit Bot
Comment 4 2013-04-08 17:21:06 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.