Summary: | [BlackBerry] WebPage: fix build due to type mismatches | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alberto Garcia <berto> | ||||
Component: | WebKit BlackBerry | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | cgarcia, commit-queue, mifenton, rwlbuis, tonikitoo, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 111729 | ||||||
Attachments: |
|
Description
Alberto Garcia
2013-04-08 00:41:09 PDT
Created attachment 196835 [details]
Patch
Comment on attachment 196835 [details]
Patch
What changed so that we need to do this?
Comment on attachment 196835 [details] Patch Clearing flags on attachment: 196835 Committed r147973: <http://trac.webkit.org/changeset/147973> All reviewed patches have been landed. Closing bug. (In reply to comment #2) > (From update of attachment 196835 [details]) > What changed so that we need to do this? This was upstreamed on year ago (r108718) and I'm not sure if it ever compiled. For example, you can't implicitly convert LayoutUnit in this case because there are several candidates: error: ambiguous overload for 'operator+=' in 'xOffset += renderBlock->WebCore::RenderBlock::<anonymous>.WebCore::RenderBox::x()' note: candidates are: note: operator+=(int&, int) <built-in> note: operator+=(int&, unsigned int) <built-in> note: operator+=(int&, float) <built-in> note: operator+=(int&, double) <built-in> |