Bug 114148

Summary:

[BlackBerry] WebPage: fix build due to type mismatches

Product:

WebKit

Reporter:

Alberto Garcia <berto>

Component:

WebKit BlackBerry

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cgarcia, commit-queue, mifenton, rwlbuis, tonikitoo, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

111729

Attachments:

Description	Flags
Patch	none

Description Alberto Garcia 2013-04-08 00:41:09 PDT

Add explicit conversions between LayoutUnit and int, and between LayoutRect and IntRect.

Comment 1 Alberto Garcia 2013-04-08 00:45:31 PDT

Created attachment 196835 [details]
Patch

Comment 2 Rob Buis 2013-04-08 04:34:24 PDT

Comment on attachment 196835 [details]
Patch

What changed so that we need to do this?

Comment 3 WebKit Commit Bot 2013-04-08 18:32:36 PDT

Comment on attachment 196835 [details]
Patch

Clearing flags on attachment: 196835

Committed r147973: <http://trac.webkit.org/changeset/147973>

Comment 4 WebKit Commit Bot 2013-04-08 18:32:38 PDT

All reviewed patches have been landed.  Closing bug.

Comment 5 Alberto Garcia 2013-04-09 00:41:26 PDT

(In reply to comment #2)
> (From update of attachment 196835 [details])
> What changed so that we need to do this?

This was upstreamed on year ago (r108718) and I'm not sure if it ever
compiled.

For example, you can't implicitly convert LayoutUnit in this case
because there are several candidates:

error: ambiguous overload for 'operator+=' in 'xOffset += renderBlock->WebCore::RenderBlock::<anonymous>.WebCore::RenderBox::x()'
note: candidates are:
note: operator+=(int&, int) <built-in>
note: operator+=(int&, unsigned int) <built-in>
note: operator+=(int&, float) <built-in>
note: operator+=(int&, double) <built-in>