Bug 114143

Summary: Regression(r147893) Caused several editing tests to fail
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Tools / TestsAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, benjamin, zarvai
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 114136    
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2013-04-07 23:35:56 PDT
<http://trac.webkit.org/changeset/147893> caused several editing test to fail with diffs such as: --- /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/layout-test-results/editing/deleting/paragraph-in-preserveNewline-expected.txt +++ /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/layout-test-results/editing/deleting/paragraph-in-preserveNewline-actual.txt @@ -34,17 +34,7 @@ EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of PRE > DIV > BODY > HTML > #document to 0 of PRE > DIV > BODY > HTML > #document toDOMRange:range from 0 of #text > PRE > DIV > BODY > HTML > #document to 3 of #text > PRE > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification -EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification -EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification -EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification -EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification -EDITING DELEGATE: shouldDeleteDOMRange:range from 0 of #text > PRE > DIV > BODY > HTML > #document to 3 of #text > PRE > DIV > BODY > HTML > #document -EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification -EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification -EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification -EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of PRE > DIV > BODY > HTML > #document to 0 of PRE > DIV > BODY > HTML > #document toDOMRange:range from 0 of #text > PRE > DIV > BODY > HTML > #document to 3 of #text > PRE > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE -EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification -EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification +CONSOLE MESSAGE: line 15: SyntaxError: DOM Exception 12: An invalid or illegal string was specified. EDITING DELEGATE: webViewDidEndEditing:WebViewDidEndEditingNotification This tests for a bug where deleting a paragraph in preserveNewline text would introduce an extra line. You should see '\nbar' below. @@ -82,13 +72,3 @@ | <pre> | "<#selection-anchor>foo<#selection-focus> bar" - -on android: -| <pre> -| "<#selection-caret> -bar" - -after undo on android: -| <pre> -| "<#selection-anchor>foo<#selection-focus> -bar"
Attachments
Patch (26.62 KB, patch)
2013-04-07 23:43 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (4.86 KB, patch)
2013-04-08 01:20 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2013-04-07 23:43:06 PDT
Created attachment 196831 [details] Patch
Benjamin Poulain
Comment 2 2013-04-07 23:49:06 PDT
Comment on attachment 196831 [details] Patch Sorry!
Benjamin Poulain
Comment 3 2013-04-07 23:51:38 PDT
Comment on attachment 196831 [details] Patch Clearing flags on attachment: 196831 Committed r147896: <http://trac.webkit.org/changeset/147896>
Benjamin Poulain
Comment 4 2013-04-07 23:51:41 PDT
All reviewed patches have been landed. Closing bug.
Zoltan Arvai
Comment 5 2013-04-08 01:04:43 PDT
It seems two other test are also affected editing/deleting/delete-ligature-003.html editing/selection/context-menu-text-selection.html
Benjamin Poulain
Comment 6 2013-04-08 01:07:48 PDT
(In reply to comment #5) > It seems two other test are also affected > > editing/deleting/delete-ligature-003.html > editing/selection/context-menu-text-selection.html Patch on the way.
Benjamin Poulain
Comment 7 2013-04-08 01:20:34 PDT
Created attachment 196838 [details] Patch
Benjamin Poulain
Comment 8 2013-04-08 01:27:15 PDT
Committed r147898: <http://trac.webkit.org/changeset/147898>
Note You need to log in before you can comment on or make changes to this bug.