Bug 114143 – Regression(r147893) Caused several editing tests to fail

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Chris Dumez]

<http://trac.webkit.org/changeset/147893> caused several editing test to fail with diffs such as:
--- /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/layout-test-results/editing/deleting/paragraph-in-preserveNewline-expected.txt
+++ /home/buildslave-1/webkit-buildslave/efl-linux-64-debug-wk2/build/layout-test-results/editing/deleting/paragraph-in-preserveNewline-actual.txt
@@ -34,17 +34,7 @@
 EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of PRE > DIV > BODY > HTML > #document to 0 of PRE > DIV > BODY > HTML > #document toDOMRange:range from 0 of #text > PRE > DIV > BODY > HTML > #document to 3 of #text > PRE > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
 EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
 EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: shouldDeleteDOMRange:range from 0 of #text > PRE > DIV > BODY > HTML > #document to 3 of #text > PRE > DIV > BODY > HTML > #document
-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
-EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of PRE > DIV > BODY > HTML > #document to 0 of PRE > DIV > BODY > HTML > #document toDOMRange:range from 0 of #text > PRE > DIV > BODY > HTML > #document to 3 of #text > PRE > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
-EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
-EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
+CONSOLE MESSAGE: line 15: SyntaxError: DOM Exception 12: An invalid or illegal string was specified.
 EDITING DELEGATE: webViewDidEndEditing:WebViewDidEndEditingNotification
 This tests for a bug where deleting a paragraph in preserveNewline text would introduce an extra line.  You should see '\nbar' below.
 
@@ -82,13 +72,3 @@
 | <pre>
 |   "<#selection-anchor>foo<#selection-focus>
 bar"
-
-on android:
-| <pre>
-|   "<#selection-caret>
-bar"
-
-after undo on android:
-| <pre>
-|   "<#selection-anchor>foo<#selection-focus>
-bar"

[Chris Dumez]

Created attachment 196831 [details]
Patch

[Benjamin Poulain]

Comment on attachment 196831 [details]
Patch

Sorry!

[Benjamin Poulain]

Comment on attachment 196831 [details]
Patch

Clearing flags on attachment: 196831

Committed r147896: <http://trac.webkit.org/changeset/147896>

[Benjamin Poulain]

All reviewed patches have been landed.  Closing bug.

[Zoltan Arvai]

It seems two other test are also affected

editing/deleting/delete-ligature-003.html
editing/selection/context-menu-text-selection.html

[Benjamin Poulain]

(In reply to comment #5)
> It seems two other test are also affected
> 
> editing/deleting/delete-ligature-003.html
> editing/selection/context-menu-text-selection.html

Patch on the way.

[Benjamin Poulain]

Created attachment 196838 [details]
Patch

[Benjamin Poulain]

Committed r147898: <http://trac.webkit.org/changeset/147898>