Bug 114110

Summary: Do not allocate static AtomicStrings when searching for alternate font names
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch ggaren: review+

Description Benjamin Poulain 2013-04-06 21:44:34 PDT
Do not allocate static AtomicStrings when searching for alternate font names
Comment 1 Benjamin Poulain 2013-04-06 22:05:27 PDT
Created attachment 196769 [details]
Patch
Comment 2 Geoffrey Garen 2013-04-07 12:38:33 PDT
Comment on attachment 196769 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=196769&action=review

r=me

> Source/WebCore/ChangeLog:25
> +        To avoid comparing the input to every string, every time, the lenght of

Typo: length.

> Source/WebCore/platform/graphics/FontCache.cpp:156
> +    // Alias Arial and Helvetica

Typo: Needs a ".".
Comment 3 Benjamin Poulain 2013-04-07 18:00:23 PDT
Committed r147889: <http://trac.webkit.org/changeset/147889>