Bug 114083

Summary: Remove remaining PLATFORM(CHROMIUM) guards in TestWebKitAPI, WebKitTestRunner
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 none

Description Zan Dobersek 2013-04-06 01:08:56 PDT
Remove remaining PLATFORM(CHROMIUM) guards in TestWebKitAPI, WebKitTestRunner
Comment 1 Zan Dobersek 2013-04-06 01:09:51 PDT
Created attachment 196721 [details]
Patch
Comment 2 Build Bot 2013-04-06 03:52:27 PDT
Comment on attachment 196721 [details]
Patch

Attachment 196721 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-commit-queue.appspot.com/results/17488461

New failing tests:
platform/mac-wk2/plugins/npp-setwindow-called-on-scroll.html
Comment 3 Build Bot 2013-04-06 03:52:28 PDT
Created attachment 196729 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.2
Comment 4 Zan Dobersek 2013-04-06 09:07:15 PDT
(In reply to comment #2)
> (From update of attachment 196721 [details])
> Attachment 196721 [details] did not pass mac-wk2-ews (mac-wk2):
> Output: http://webkit-commit-queue.appspot.com/results/17488461
> 
> New failing tests:
> platform/mac-wk2/plugins/npp-setwindow-called-on-scroll.html

This is a flaky test, not caused by the patch.
http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20webkit.org&tests=platform%2Fmac-wk2%2Fplugins%2Fnpp-setwindow-called-on-scroll.html
Comment 5 Zan Dobersek 2013-04-06 14:18:00 PDT
Comment on attachment 196721 [details]
Patch

Clearing flags on attachment: 196721

Committed r147853: <http://trac.webkit.org/changeset/147853>
Comment 6 Zan Dobersek 2013-04-06 14:18:04 PDT
All reviewed patches have been landed.  Closing bug.