Bug 114069

Summary: [EFL] --minimal build fails with error: ‘class WebKit::DrawingAreaProxy’ has no member named ‘setVisibleContentsRect’
Product: WebKit Reporter: Ed Bartosh <bartosh>
Component: WebKit EFLAssignee: Ed Bartosh <bartosh>
Status: RESOLVED WONTFIX    
Severity: Normal CC: gyuyoung.kim, kalyan.kondapally, kenneth, laszlo.gombos, lucas.de.marchi, mcatanzaro, rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch gyuyoung.kim: review-

Ed Bartosh
Reported 2013-04-05 15:31:35 PDT
./Tools/Scripts/build-webkit --efl --cmakeargs="-DSHARED_CORE=ON" --minimal fails with this error: /home/ed/git/wk/WebKit/Source/WebKit2/UIProcess/efl/WebView.cpp: In member function ‘void WebKit::WebView::updateViewportSize()’: /home/ed/git/wk/WebKit/Source/WebKit2/UIProcess/efl/WebView.cpp:287:22: error: ‘class WebKit::DrawingAreaProxy’ has no member named ‘setVisibleContentsRect’ /home/ed/git/wk/WebKit/Source/WebKit2/UIProcess/efl/WebView.cpp: At global scope: /home/ed/git/wk/WebKit/Source/WebKit2/UIProcess/efl/WebView.cpp:543:6: warning: unused parameter ‘attr’ [-Wunused-parameter] /home/ed/git/wk/WebKit/Source/WebKit2/UIProcess/efl/WebView.cpp:568:6: warning: unused parameter ‘contentsSize’ [-Wunused-parameter] /home/ed/git/wk/WebKit/Source/WebKit2/UIProcess/efl/WebView.cpp:568:6: warning: unused parameter ‘coveredRect’ [-Wunused-parameter] make[2]: *** [Source/WebKit2/CMakeFiles/ewebkit2.dir/UIProcess/efl/WebView.cpp.o] Error 1 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [Source/WebKit2/CMakeFiles/ewebkit2.dir/all] Error 2 make: *** [all] Error 2
Attachments
Patch (1.46 KB, patch)
2013-04-05 15:54 PDT, Ed Bartosh 		no flags
DetailsFormatted DiffDiff
Patch (1.50 KB, patch)
2013-04-07 13:28 PDT, Ed Bartosh 		no flags
DetailsFormatted DiffDiff
Patch (1.49 KB, patch)
2013-04-13 04:21 PDT, Ed Bartosh 		no flags
DetailsFormatted DiffDiff
Patch (1.49 KB, patch)
2013-04-21 10:44 PDT, Ed Bartosh 		no flags
DetailsFormatted DiffDiff
Patch (1.24 KB, patch)
2013-05-10 13:01 PDT, Ed Bartosh 		gyuyoung.kim: review-
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Ed Bartosh
Comment 1 2013-04-05 15:54:19 PDT
Created attachment 196693 [details] Patch
Ed Bartosh
Comment 2 2013-04-07 13:28:42 PDT
Created attachment 196811 [details] Patch Rebased. Please, review.
Ed Bartosh
Comment 3 2013-04-09 14:29:55 PDT
Guys, please review. It's a trivial change.
Ed Bartosh
Comment 4 2013-04-13 04:21:32 PDT
Created attachment 197933 [details] Patch
Ed Bartosh
Comment 5 2013-04-21 10:44:15 PDT
Created attachment 198968 [details] Patch
Laszlo Gombos
Comment 6 2013-04-22 20:19:40 PDT
Ed, is the resulting binary functional ? I am not sure if WebKit2 on and COORDINATED_GRAPHICS off is an actual configuration that is expected to work.
Ed Bartosh
Comment 7 2013-04-23 13:09:20 PDT
I don't know if it works or not. Just trying to fix --minimal build. Do you have another suggestions how to fix this build failure?
Ed Bartosh
Comment 8 2013-05-10 13:01:18 PDT
Created attachment 201382 [details] Patch
Ed Bartosh
Comment 9 2013-05-10 13:08:57 PDT
What about to explicitly enable coordinated graphics for WebKit2 efl (see attached patch) ?
Gyuyoung Kim
Comment 10 2013-05-13 03:03:57 PDT
Comment on attachment 201382 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=201382&action=review > Source/cmake/OptionsEfl.cmake:155 > +if (ENABLE_WEBKIT2) When we use --minimal option, tiled backing store is disabled. So, coordinate graphics is also disabled. As far as I know, coordinate graphics is depend on tiled backing store. I don't agree to enable coordinated graphics without tiled backing store. I think you need to find other method to fix this build break.
Gyuyoung Kim
Comment 11 2013-10-20 22:28:31 PDT
Comment on attachment 201382 [details] Patch r- based on my comment.
Michael Catanzaro
Comment 12 2017-03-11 10:43:50 PST
Closing this bug because the EFL port has been removed from trunk. If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this.
Note You need to log in before you can comment on or make changes to this bug.