Summary: | [EFL] --minimal build fails with error: ‘class WebKit::DrawingAreaProxy’ has no member named ‘setVisibleContentsRect’ | ||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ed Bartosh <bartosh> | ||||||||||||
Component: | WebKit EFL | Assignee: | Ed Bartosh <bartosh> | ||||||||||||
Status: | RESOLVED WONTFIX | ||||||||||||||
Severity: | Normal | CC: | gyuyoung.kim, kalyan.kondapally, kenneth, laszlo.gombos, lucas.de.marchi, mcatanzaro, rakuco, webkit.review.bot | ||||||||||||
Priority: | P2 | ||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||
Hardware: | Unspecified | ||||||||||||||
OS: | Unspecified | ||||||||||||||
Attachments: |
|
Description
Ed Bartosh
2013-04-05 15:31:35 PDT
Created attachment 196693 [details]
Patch
Created attachment 196811 [details]
Patch
Rebased. Please, review.
Guys, please review. It's a trivial change. Created attachment 197933 [details]
Patch
Created attachment 198968 [details]
Patch
Ed, is the resulting binary functional ? I am not sure if WebKit2 on and COORDINATED_GRAPHICS off is an actual configuration that is expected to work. I don't know if it works or not. Just trying to fix --minimal build. Do you have another suggestions how to fix this build failure? Created attachment 201382 [details]
Patch
What about to explicitly enable coordinated graphics for WebKit2 efl (see attached patch) ? Comment on attachment 201382 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=201382&action=review > Source/cmake/OptionsEfl.cmake:155 > +if (ENABLE_WEBKIT2) When we use --minimal option, tiled backing store is disabled. So, coordinate graphics is also disabled. As far as I know, coordinate graphics is depend on tiled backing store. I don't agree to enable coordinated graphics without tiled backing store. I think you need to find other method to fix this build break. Comment on attachment 201382 [details]
Patch
r- based on my comment.
Closing this bug because the EFL port has been removed from trunk. If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this. |