Bug 114061

Summary:

[GTK] Change from PLATFORM(GTK) to USE(GLIB) in WTF/CurrentTime.cpp

Product:

WebKit

Reporter:

Jesus Sanchez-Palencia <jesus>

Component:

New Bugs

Assignee:

Jesus Sanchez-Palencia <jesus>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, cmarcelo, commit-queue, gergely, gustavo, kilvadyb, ojan.autocc, ossy, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Jesus Sanchez-Palencia

Reported 2013-04-05 13:44:37 PDT

[GTK] Change from PLATFORM(GTK) to USE(GLIB) in WTF/CurrentTime.cpp

Attachments
Patch (1.66 KB, patch) 2013-04-05 13:47 PDT, Jesus Sanchez-Palencia	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Jesus Sanchez-Palencia

Comment 1 2013-04-05 13:47:20 PDT

Created attachment 196675 [details] Patch

WebKit Commit Bot

Comment 2 2013-04-05 14:45:43 PDT

Comment on attachment 196675 [details] Patch Clearing flags on attachment: 196675 Committed r147799: <http://trac.webkit.org/changeset/147799>

WebKit Commit Bot

Comment 3 2013-04-05 14:45:45 PDT

All reviewed patches have been landed. Closing bug.

Csaba Osztrogonác

Comment 4 2013-04-08 05:40:27 PDT

(In reply to comment #2) > (From update of attachment 196675 [details]) > Clearing flags on attachment: 196675 > > Committed r147799: <http://trac.webkit.org/changeset/147799> It broke the Qt MIPS build. It seems Qt-MIPS port uses GLIB: /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/WTF/wtf/CurrentTime.cpp: In function 'double WTF::monotonicallyIncreasingTime()': /data/buildbot/mips-1/qt-linux-mipsel-mips32r2-release/build/Source/WTF/wtf/CurrentTime.cpp:298: error: 'g_get_monotonic_time' was not declared in this scope I cc-ed MIPS maintainters.

Csaba Osztrogonác

Comment 5 2013-04-08 05:44:03 PDT

Not only MIPS, but Qt port uses GLIB if GStreamer is used.

Jesus Sanchez-Palencia

Comment 6 2013-04-08 05:54:11 PDT

(In reply to comment #5) > Not only MIPS, but Qt port uses GLIB if GStreamer is used. If Qt doesn't want to use the GLib implementation, being it for MIPS or not, then I can add a !PLATFORM(QT) there. What do you think?

Csaba Osztrogonác

Comment 7 2013-04-08 05:57:16 PDT

(In reply to comment #6) > (In reply to comment #5) > > Not only MIPS, but Qt port uses GLIB if GStreamer is used. > > If Qt doesn't want to use the GLib implementation, being it for MIPS or not, then I can add a !PLATFORM(QT) there. > > What do you think? I exactly thought this fix and then landed in http://trac.webkit.org/changeset/147910 :)

Note You need to log in before you can comment on or make changes to this bug.