Bug 114010 – Clean the chromium bits of WebCore's WebDatabase

• Component: New Bugs
• Status: RESOLVED FIXED

[Benjamin Poulain]

Clean the chromium bits of WebCore's WebDatabase

[Benjamin Poulain]

Created attachment 196594 [details]
Patch

[Mark Lam]

Comment on attachment 196594 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=196594&action=review

LGTM with the getCachedVersion() issue addressed.  Thanks.

> Source/WebCore/Modules/webdatabase/DatabaseBackendBase.cpp:-533
> -    return getVersionFromDatabase(actualVersion, true);

We will want to adopt this for WK2 instead of the getCachedVersion() below.

[Benjamin Poulain]

(In reply to comment #2)
> (From update of attachment 196594 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=196594&action=review
> 
> LGTM with the getCachedVersion() issue addressed.  Thanks.
> 
> > Source/WebCore/Modules/webdatabase/DatabaseBackendBase.cpp:-533
> > -    return getVersionFromDatabase(actualVersion, true);
> 
> We will want to adopt this for WK2 instead of the getCachedVersion() below.

I am not sure what you are asking.

You want to keep dead code around? Or you want to remove the #else part and use the former chromium part?

[Mark Lam]

(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 196594 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=196594&action=review
> > 
> > LGTM with the getCachedVersion() issue addressed.  Thanks.
> > 
> > > Source/WebCore/Modules/webdatabase/DatabaseBackendBase.cpp:-533
> > > -    return getVersionFromDatabase(actualVersion, true);
> > 
> > We will want to adopt this for WK2 instead of the getCachedVersion() below.
> 
> I am not sure what you are asking.
> 
> You want to keep dead code around? Or you want to remove the #else part and use the former chromium part?

I meant to say that we should keep the chromium version here and get rid of the other.  In this one case, the chromium version is the correct one to use because of WK2’s needs.

[Benjamin Poulain]

Committed r147796: <http://trac.webkit.org/changeset/147796>