Bug 113975

Summary: WebKit should not expose AXSubrole:AXDescriptionList on Mountain Lion as it causes a regression in VoiceOver behavior
Product: WebKit Reporter: James Craig <jcraig>
Component: AccessibilityAssignee: James Craig <jcraig>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, jcraig, jdiggs, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch with review feedback none

James Craig
Reported 2013-04-04 16:27:25 PDT
WebKit should not expose AXSubrole:AXDescriptionList on Mountain Lion as it causes a regression in VoiceOver behavior. Should just use the old AXDefinitionList.
Attachments
patch (6.85 KB, patch)
2013-04-12 13:24 PDT, James Craig 		no flags
DetailsFormatted DiffDiff
patch with review feedback (6.67 KB, patch)
2013-04-12 16:10 PDT, James Craig 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2013-04-04 16:28:54 PDT
<rdar://problem/13582264>
James Craig
Comment 2 2013-04-12 13:24:04 PDT
Created attachment 197879 [details] patch
chris fleizach
Comment 3 2013-04-12 15:22:50 PDT
Comment on attachment 197879 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=197879&action=review > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:1759 > + // fall back to NSAccessibilityDefinitionListSubrole in 10.8 and earlier you can remove this comment. it is self-evident by reading the code > Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:1760 > + #if __MAC_OS_X_VERSION_MIN_REQUIRED < 1090 these macros should start at the beginning of the line
James Craig
Comment 4 2013-04-12 16:10:06 PDT
Created attachment 197903 [details] patch with review feedback
WebKit Commit Bot
Comment 5 2013-04-15 18:33:02 PDT
Comment on attachment 197903 [details] patch with review feedback Clearing flags on attachment: 197903 Committed r148484: <http://trac.webkit.org/changeset/148484>
WebKit Commit Bot
Comment 6 2013-04-15 18:33:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.