Bug 11396

Summary: KRenderingFill-/StrokePainter needs to die
Product: WebKit Reporter: Nikolas Zimmermann <zimmermann>
Component: SVGAssignee: Nikolas Zimmermann <zimmermann>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Attachments:
Description Flags
Initial patch
aroben: review+
Updated patch aroben: review+

Nikolas Zimmermann
Reported 2006-10-24 03:34:16 PDT
As one of the first parts in the "kcanvas restructurization", we can remove KRenderingFillPainter/KRenderingStrokePainter from kcanvas, and it's usage from the Quartz/Qt devices. I'll upload a patch ASAP for this.
Attachments
Initial patch (56.73 KB, patch)
2006-10-24 04:10 PDT, Nikolas Zimmermann 		aroben: review+
DetailsFormatted DiffDiff
Updated patch (56.79 KB, patch)
2006-10-24 10:25 PDT, Nikolas Zimmermann 		aroben: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nikolas Zimmermann
Comment 1 2006-10-24 04:10:02 PDT
Created attachment 11190 [details] Initial patch This kills any usage of KRenderingFillPainter/KRenderingStrokePainter. Patch includes Qt/Quartz modifications, removal of the KRenderingFill/StrokePainter files, and build system adjustments. No new logic introduced, no regression tests altered.
Adam Roben (:aroben)
Comment 2 2006-10-24 10:14:05 PDT
Comment on attachment 11190 [details] Initial patch #import "SVGRenderStyle.h" #import "SVGStyledElement.h" +#import "KCanvasRenderingStyle.h" Please make these #imports alphabetical +void applyStrokeStyleToContext(CGContextRef context, RenderStyle* style, const RenderObject* object) +FloatRect strokeBoundingBox(const Path& path, RenderStyle* style, const RenderObject* object) Can these take a const RenderStyle*? #include "SVGPaint.h" +#include "GraphicsTypes.h" Alphabetical, please. SVN will not be happy if you leave the tabs in WebCore/ksvg2/misc/KCanvasRenderingStyle.cpp :-) r=me
Nikolas Zimmermann
Comment 3 2006-10-24 10:25:12 PDT
Created attachment 11191 [details] Updated patch Incorporated Adam's comments.
Adam Roben (:aroben)
Comment 4 2006-10-24 10:34:35 PDT
Comment on attachment 11191 [details] Updated patch r=me
Mark Rowe (bdash)
Comment 5 2006-10-24 13:09:57 PDT
Landed in r17257.
Note You need to log in before you can comment on or make changes to this bug.