Summary: | KRenderingFill-/StrokePainter needs to die | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nikolas Zimmermann <zimmermann> | ||||||
Component: | SVG | Assignee: | Nikolas Zimmermann <zimmermann> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | ||||||||
Priority: | P2 | ||||||||
Version: | 420+ | ||||||||
Hardware: | Mac | ||||||||
OS: | OS X 10.4 | ||||||||
Attachments: |
|
Description
Nikolas Zimmermann
2006-10-24 03:34:16 PDT
Created attachment 11190 [details]
Initial patch
This kills any usage of KRenderingFillPainter/KRenderingStrokePainter. Patch includes
Qt/Quartz modifications, removal of the KRenderingFill/StrokePainter files, and build
system adjustments.
No new logic introduced, no regression tests altered.
Comment on attachment 11190 [details]
Initial patch
#import "SVGRenderStyle.h"
#import "SVGStyledElement.h"
+#import "KCanvasRenderingStyle.h"
Please make these #imports alphabetical
+void applyStrokeStyleToContext(CGContextRef context, RenderStyle* style, const RenderObject* object)
+FloatRect strokeBoundingBox(const Path& path, RenderStyle* style, const RenderObject* object)
Can these take a const RenderStyle*?
#include "SVGPaint.h"
+#include "GraphicsTypes.h"
Alphabetical, please.
SVN will not be happy if you leave the tabs in WebCore/ksvg2/misc/KCanvasRenderingStyle.cpp :-)
r=me
Created attachment 11191 [details]
Updated patch
Incorporated Adam's comments.
Comment on attachment 11191 [details]
Updated patch
r=me
|