Bug 11396 - KRenderingFill-/StrokePainter needs to die
Summary: KRenderingFill-/StrokePainter needs to die
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 420+
Hardware: Mac OS X 10.4
: P2 Normal
Assignee: Nikolas Zimmermann
Depends on:
Reported: 2006-10-24 03:34 PDT by Nikolas Zimmermann
Modified: 2006-10-24 13:09 PDT (History)
0 users

See Also:

Initial patch (56.73 KB, patch)
2006-10-24 04:10 PDT, Nikolas Zimmermann
aroben: review+
Details | Formatted Diff | Diff
Updated patch (56.79 KB, patch)
2006-10-24 10:25 PDT, Nikolas Zimmermann
aroben: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2006-10-24 03:34:16 PDT
As one of the first parts in the "kcanvas restructurization", we can remove
KRenderingFillPainter/KRenderingStrokePainter from kcanvas, and it's usage
from the Quartz/Qt devices.

I'll upload a patch ASAP for this.
Comment 1 Nikolas Zimmermann 2006-10-24 04:10:02 PDT
Created attachment 11190 [details]
Initial patch

This kills any usage of KRenderingFillPainter/KRenderingStrokePainter. Patch includes
Qt/Quartz modifications, removal of the KRenderingFill/StrokePainter files, and build
system adjustments.

No new logic introduced, no regression tests altered.
Comment 2 Adam Roben (:aroben) 2006-10-24 10:14:05 PDT
Comment on attachment 11190 [details]
Initial patch

 #import "SVGRenderStyle.h"
 #import "SVGStyledElement.h"
+#import "KCanvasRenderingStyle.h"

Please make these #imports alphabetical

+void applyStrokeStyleToContext(CGContextRef context, RenderStyle* style, const RenderObject* object)
+FloatRect strokeBoundingBox(const Path& path, RenderStyle* style, const RenderObject* object)

Can these take a const RenderStyle*?

 #include "SVGPaint.h"
+#include "GraphicsTypes.h"

Alphabetical, please.

SVN will not be happy if you leave the tabs in WebCore/ksvg2/misc/KCanvasRenderingStyle.cpp :-)

Comment 3 Nikolas Zimmermann 2006-10-24 10:25:12 PDT
Created attachment 11191 [details]
Updated patch

Incorporated Adam's comments.
Comment 4 Adam Roben (:aroben) 2006-10-24 10:34:35 PDT
Comment on attachment 11191 [details]
Updated patch

Comment 5 Mark Rowe (bdash) 2006-10-24 13:09:57 PDT
Landed in r17257.