Bug 113938

Summary: Element: Unionize tagQName and elementData to save space.
Product: WebKit Reporter: Andreas Kling <kling>
Component: DOMAssignee: Andreas Kling <kling>
Status: RESOLVED WONTFIX    
Severity: Normal CC: cmarcelo, esprehn+autocc, kling, koivisto, ojan.autocc, webkit.review.bot
Priority: P2 Keywords: Performance
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 109505    
Attachments:
Description Flags
Breakfast for EWS
buildbot: commit-queue-
Lunch for EWS
none
Dinner for EWS none

Andreas Kling
Reported 2013-04-04 09:24:01 PDT
We could shrink attribute-less Elements by one pointer if we unionize tagQName() and elementData().
Attachments
Breakfast for EWS (22.30 KB, patch)
2013-04-04 09:37 PDT, Andreas Kling 		buildbot: commit-queue-
DetailsFormatted DiffDiff
Lunch for EWS (23.00 KB, patch)
2013-04-06 01:24 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Dinner for EWS (22.83 KB, patch)
2013-04-07 06:49 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2013-04-04 09:37:05 PDT
Created attachment 196485 [details] Breakfast for EWS
Build Bot
Comment 2 2013-04-04 23:19:47 PDT
Comment on attachment 196485 [details] Breakfast for EWS Attachment 196485 [details] did not pass win-ews (win): Output: http://webkit-commit-queue.appspot.com/results/17488040
Andreas Kling
Comment 3 2013-04-06 01:24:36 PDT
Created attachment 196722 [details] Lunch for EWS
WebKit Review Bot
Comment 4 2013-04-06 15:45:15 PDT
Attachment 196722 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/dom/DocumentSharedObjectPool.cpp', u'Source/WebCore/dom/DocumentSharedObjectPool.h', u'Source/WebCore/dom/Element.cpp', u'Source/WebCore/dom/Element.h', u'Source/WebCore/dom/Node.h']" exit_code: 1 Source/WebCore/dom/Element.cpp:2957: One line control clauses should not use braces. [whitespace/braces] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andreas Kling
Comment 5 2013-04-07 06:49:05 PDT
Created attachment 196785 [details] Dinner for EWS
Andreas Kling
Comment 6 2017-03-14 13:12:27 PDT
Let's not do this cheesy micro-optimization.
Note You need to log in before you can comment on or make changes to this bug.