Bug 113938 - Element: Unionize tagQName and elementData to save space.
Summary: Element: Unionize tagQName and elementData to save space.
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
Keywords: Performance
Depends on:
Blocks: 109505
  Show dependency treegraph
Reported: 2013-04-04 09:24 PDT by Andreas Kling
Modified: 2017-03-14 13:12 PDT (History)
6 users (show)

See Also:

Breakfast for EWS (22.30 KB, patch)
2013-04-04 09:37 PDT, Andreas Kling
buildbot: commit-queue-
Details | Formatted Diff | Diff
Lunch for EWS (23.00 KB, patch)
2013-04-06 01:24 PDT, Andreas Kling
no flags Details | Formatted Diff | Diff
Dinner for EWS (22.83 KB, patch)
2013-04-07 06:49 PDT, Andreas Kling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-04-04 09:24:01 PDT
We could shrink attribute-less Elements by one pointer if we unionize tagQName() and elementData().
Comment 1 Andreas Kling 2013-04-04 09:37:05 PDT
Created attachment 196485 [details]
Breakfast for EWS
Comment 2 Build Bot 2013-04-04 23:19:47 PDT
Comment on attachment 196485 [details]
Breakfast for EWS

Attachment 196485 [details] did not pass win-ews (win):
Output: http://webkit-commit-queue.appspot.com/results/17488040
Comment 3 Andreas Kling 2013-04-06 01:24:36 PDT
Created attachment 196722 [details]
Lunch for EWS
Comment 4 WebKit Review Bot 2013-04-06 15:45:15 PDT
Attachment 196722 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/dom/DocumentSharedObjectPool.cpp', u'Source/WebCore/dom/DocumentSharedObjectPool.h', u'Source/WebCore/dom/Element.cpp', u'Source/WebCore/dom/Element.h', u'Source/WebCore/dom/Node.h']" exit_code: 1
Source/WebCore/dom/Element.cpp:2957:  One line control clauses should not use braces.  [whitespace/braces] [4]
Total errors found: 1 in 5 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Andreas Kling 2013-04-07 06:49:05 PDT
Created attachment 196785 [details]
Dinner for EWS
Comment 6 Andreas Kling 2017-03-14 13:12:27 PDT
Let's not do this cheesy micro-optimization.