Bug 113924

Summary: AX:File upload button has wrong label
Product: WebKit Reporter: chris fleizach <cfleizach>
Component: AccessibilityAssignee: chris fleizach <cfleizach>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, dmazzoni, jdiggs, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
patch ddkilzer: review+

Description chris fleizach 2013-04-03 23:48:00 PDT
The file upload button for iOS has the wrong label
Comment 1 chris fleizach 2013-04-03 23:48:38 PDT
Created attachment 196443 [details]
patch
Comment 2 WebKit Review Bot 2013-04-03 23:52:38 PDT
Attachment 196443 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/platform/iphone-simulator/accessibility/file-upload-button-expected.txt', u'LayoutTests/platform/iphone-simulator/accessibility/file-upload-button.html', u'Source/WebCore/ChangeLog', u'Source/WebCore/accessibility/ios/WebAccessibilityObjectWrapperIOS.mm', u'Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperBase.mm']" exit_code: 1
LayoutTests/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 chris fleizach 2013-04-03 23:53:58 PDT
Created attachment 196444 [details]
patch
Comment 4 David Kilzer (:ddkilzer) 2013-04-04 11:00:46 PDT
Comment on attachment 196444 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=196444&action=review

r=me, but consider adding a mac layout test (result) as well.

> Source/WebCore/ChangeLog:11
> +        Test: platform/iphone-simulator/accessibility/file-upload-button.html

Shouldn't there be a Mac test as well?  Or a test that runs on both Mac and iOS?
Comment 5 chris fleizach 2013-04-04 11:01:50 PDT
(In reply to comment #4)
> (From update of attachment 196444 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=196444&action=review
> 
> r=me, but consider adding a mac layout test (result) as well.
> 
> > Source/WebCore/ChangeLog:11
> > +        Test: platform/iphone-simulator/accessibility/file-upload-button.html
> 
> Shouldn't there be a Mac test as well?  Or a test that runs on both Mac and iOS?

We already test this on the Mac with its own layout test. Due to the API differences the right label wasn't coming through for iOS, so it will only affect iOS

Thanks
Comment 6 chris fleizach 2013-04-04 12:04:11 PDT
http://trac.webkit.org/changeset/147660