Bug 113909

Summary:

Add comment to clarify isStackingContext() in RenderLayer.h

Product:

WebKit

Reporter:

Shawn Singh <shawnsingh>

Component:

Layout and Rendering

Assignee:

Shawn Singh <shawnsingh>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

eric, esprehn+autocc, esprehn, ojan.autocc, simon.fraser, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
=Adjusted comment, patch for landing	none

Description Shawn Singh 2013-04-03 16:36:14 PDT

Trivial patch coming in a moment - please feel free to WontFix or cq+ this patch as you prefer. Thanks!

Comment 1 Shawn Singh 2013-04-03 16:38:39 PDT

Created attachment 196423 [details]
Patch

Comment 2 Elliott Sprehn 2013-04-03 16:42:06 PDT

Comment on attachment 196423 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=196423&action=review

> Source/WebCore/rendering/RenderLayer.h:861
> +    //       from the StyleResolver code.

"Only stacking contexts have non-auto z-index because of code in StyleResolver::adjustRenderStyle" might be nicer, either way mentioning adjustRenderStyle is probably good. I also don't think we usually use Note: in webcore, but I don't have a strong opinion on that.

Comment 3 Shawn Singh 2013-04-03 16:55:07 PDT

Created attachment 196424 [details]
=Adjusted comment, patch for landing

Comment 4 Shawn Singh 2013-04-03 16:56:01 PDT

oops - i meant to do cq+   esphren, can you please r+ again

The logic flow of your suggested version felt backwards in my opinion, hope this comment is OK.

Comment 5 Elliott Sprehn 2013-04-03 16:57:01 PDT

(In reply to comment #2)
> (From update of attachment 196423 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=196423&action=review
> 
> > Source/WebCore/rendering/RenderLayer.h:861
> > +    //       from the StyleResolver code.
> 
> "Only stacking contexts have non-auto z-index because of code in StyleResolver::adjustRenderStyle" might be nicer, either way mentioning adjustRenderStyle is probably good. I also don't think we usually use Note: in webcore, but I don't have a strong opinion on that.

(In reply to comment #4)
> oops - i meant to do cq+   esphren, can you please r+ again
> 
> The logic flow of your suggested version felt backwards in my opinion, hope this comment is OK.

nah, looks good to me.

Comment 6 WebKit Review Bot 2013-04-03 18:01:23 PDT

Comment on attachment 196424 [details]
=Adjusted comment, patch for landing

Clearing flags on attachment: 196424

Committed r147600: <http://trac.webkit.org/changeset/147600>

Comment 7 WebKit Review Bot 2013-04-03 18:01:27 PDT

All reviewed patches have been landed.  Closing bug.