Bug 113906

Summary: when ARIA button contains a link, label text is ignored (affects main buttons on m.facebook.com)
Product: WebKit Reporter: James Craig <jcraig>
Component: AccessibilityAssignee: chris fleizach <cfleizach>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, apinheiro, cfleizach, dmazzoni, jcraig, jdiggs, thorton, webkit-bug-importer, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
test case
none
code
none
patch thorton: review+

Description James Craig 2013-04-03 16:06:38 PDT
Created attachment 196421 [details]
test case

when ARIA button contains a link, label text is ignored (affects main buttons on m.facebook.com)

For example, these two buttons have empty AXTitle and AXDescription values. Attached test case.

<div role="button"><a href="#">foo</a></div>
<button><a href="#">foo</a></button>
Comment 1 James Craig 2013-04-03 16:07:39 PDT
<rdar://problem/13289394>
Comment 2 chris fleizach 2013-04-08 09:32:15 PDT
Created attachment 196864 [details]
code
Comment 3 chris fleizach 2013-04-08 09:51:20 PDT
Created attachment 196866 [details]
patch
Comment 4 chris fleizach 2013-04-08 09:51:41 PDT
Adding Tim to help with review
Comment 5 Tim Horton 2013-04-10 12:51:08 PDT
Comment on attachment 196866 [details]
patch 

View in context: https://bugs.webkit.org/attachment.cgi?id=196866&action=review

> Source/WebCore/accessibility/AccessibilityObject.h:674
> +    virtual bool isDescendantOfBarrenParent() const { return false; }

This is a bizarre name but it was already in the tree...
Comment 6 chris fleizach 2013-04-10 13:44:47 PDT
http://trac.webkit.org/changeset/148136