Summary: | when ARIA button contains a link, label text is ignored (affects main buttons on m.facebook.com) | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | James Craig <jcraig> | ||||||||
Component: | Accessibility | Assignee: | chris fleizach <cfleizach> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | aboxhall, apinheiro, cfleizach, dmazzoni, jcraig, jdiggs, thorton, webkit-bug-importer, webkit.review.bot | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Created attachment 196864 [details]
code
Created attachment 196866 [details]
patch
Adding Tim to help with review Comment on attachment 196866 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=196866&action=review > Source/WebCore/accessibility/AccessibilityObject.h:674 > + virtual bool isDescendantOfBarrenParent() const { return false; } This is a bizarre name but it was already in the tree... |
Created attachment 196421 [details] test case when ARIA button contains a link, label text is ignored (affects main buttons on m.facebook.com) For example, these two buttons have empty AXTitle and AXDescription values. Attached test case. <div role="button"><a href="#">foo</a></div> <button><a href="#">foo</a></button>