Bug 113902 – [EFL] --minimal build fails because of incorrect usage of GENERATE_THEME in CMakeLists.txt

• Component: WebKit EFL
• Status: RESOLVED FIXED

[Ed Bartosh]

./Tools/Scripts/build-webkit --efl --cmakeargs="-DSHARED_CORE=ON" --minimal fails with this error:

[Creating forwarding header foScanning dependencies of target DefaultTheme
[  0%] Generating ../../../../../WebCore/platform/efl/DefaultTheme/default.edj
edje_cc: Error. file not found:  -DCURSOR_IMAGE_DIR=/home/ed/git/wk/WebKit/Source/WebCore/Resources.
Usage:
        edje_cc [OPTIONS] input_file.edc [output_file.edj]

Where OPTIONS is one or more of:

-w files.txt             Dump all sources files path into files.txt
-id image/directory      Add a directory to look in for relative path images
-fd font/directory       Add a directory to look in for relative path fonts
-sd sound/directory      Add a directory to look in for relative pathCMakeLists.txt sounds samples
-td temp/directory       Directory to store temporary files
-v                       Verbose output
-no-lossy                Do NOT allow images to be lossy
-no-comp                 Do NOT allow images to be stored with lossless compression
-no-raw                  Do NOT allow images to be stored with zero compression (raw)
-no-save                 Do NOT store the input EDC file in the EDJ file
-min-quality VAL         Do NOT allow lossy images with quality < VAL (0-100)
-max-quality VAL         Do NOT allow lossy images with quality > VAL (0-100)
-Ddefine_val=to          CPP style define to define input macro definitions to the .edc source
-fastcomp                Use a faster compression algorithm (LZ4) (mutually exclusive with -fastdecomp)
-fastdecomp              Use a faster decompression algorithm (LZ4HC) (mutually exclusive with -fastcomp)
-threads                 Compile the edje file using multiple parallel threads (by default)
-nothreads               Compile the edje file using only the main loop
make[2]: *** [WebCore/platform/efl/DefaultTheme/default.edj] Error 255
make[1]: *** [Source/WebCore/platform/efl/DefaultTheme/CMakeFiles/DefaultTheme.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....

[Ed Bartosh]

Created attachment 196416 [details]
Patch

[Ed Bartosh]

Created attachment 196725 [details]
Patch

Rebased. Please, review.

[Ed Bartosh]

Created attachment 196806 [details]
Patch

Rebased again. Please review.

[Patrick R. Gansterer]

There is no need to rebase your change all the time as long there is no conflict. ChangeLogs get merged by resolve-ChangeLogs. If you use git there are some infos at http://trac.webkit.org/wiki/UsingGitWithWebKit#WebKitScriptsupportforGit

[Patrick R. Gansterer]

Committed r147886: <http://trac.webkit.org/changeset/147886>