Bug 113898 – Clean up the occlusion handler registration / unregistration code

• Component: WebKit2
• Status: RESOLVED FIXED

[Mark Rowe (bdash)]

There's a lot of duplication that can easily be removed.

[Mark Rowe (bdash)]

Created attachment 196409 [details]
Patch v1

[Kiran Muppala]

Comment on attachment 196409 [details]
Patch v1

static const OcclusionNotificationHandler occlusionNotificationHandlers[] = {
 156    { WKOcclusionNotificationTypeApplicationBecameVisible, applicationBecameVisible, "Application Became Visible" },
 157    { WKOcclusionNotificationTypeApplicationBecameOccluded, applicationBecameOccluded, "Application Became Occluded" },
 158    { WKOcclusionNotificationTypeApplicationWindowModificationsStarted, applicationWindowModificationsStarted, "Application Window Modifications Started" },
 159    { WKOcclusionNotificationTypeApplicationWindowModificationsStopped, applicationWindowModificationsStopped, "Application Window Modifications Stopped" },
 160};

Minor observation: The registration of visible notification used to precede the occluded notification and the order was reversed for unregistration.  Just a defensive style.  Since the order is now fixed, the log line can be replaced with an ASSERT and eliminate the return statement entirely.

[Mark Rowe (bdash)]

Created attachment 196417 [details]
Revised patch

Revised patch for reference. Removes some unnecessary consts that Darin mentioned to me, and changes the WTFLogAlways to ASSERT_WITH_MESSAGE.

[Mark Rowe (bdash)]

This was landed back in r147593.