Bug 113889

Summary: Web Inspector: InspectorPageAgent::disable unconditionally reenables JavaScript execution
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Web Inspector (Deprecated)Assignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, webkit.review.bot, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Proposed Change none

Description Timothy Hatcher 2013-04-03 12:27:53 PDT 
InspectorPageAgent::disable forces JavaScript to be enabled even if the user didn't change it via the protocol.
Comment 1 Timothy Hatcher 2013-04-03 12:31:09 PDT 
Created attachment 196391 [details]
Proposed Change
Comment 2 Joseph Pecoraro 2013-04-03 12:42:04 PDT 
Comment on attachment 196391 [details]
Proposed Change

Maybe the Inspector should be more careful about toggling the setting for the entire frame tree instead of just the main frame. But your change here doesn't change that behavior.
Comment 3 WebKit Review Bot 2013-04-03 13:37:49 PDT 
Comment on attachment 196391 [details]
Proposed Change

Clearing flags on attachment: 196391

Committed r147580: <http://trac.webkit.org/changeset/147580>
Comment 4 WebKit Review Bot 2013-04-03 13:37:52 PDT 
All reviewed patches have been landed.  Closing bug.