Bug 113873

Summary: WinCairo build fails to link.
Product: WebKit Reporter: peavo
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Unspecified   
Attachments:
Description Flags
Patch none

peavo
Reported 2013-04-03 06:50:10 PDT
The symbols FrameView::setHeaderHeight(int) and FrameView::setFooterHeight(int) are reported as unresolved externals. They are only compiled if ACCELERATED_COMPOSITING is used.
Attachments
Patch (3.54 KB, patch)
2013-04-03 07:00 PDT, peavo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
peavo
Comment 1 2013-04-03 07:00:59 PDT
Created attachment 196345 [details] Patch
peavo
Comment 2 2013-04-03 07:02:05 PDT
Removed double guards for USE(ACCELERATED_COMPOSITING), and moved methods out of USE(ACCELERATED_COMPOSITING) guard to fix linker errors.
Brent Fulgham
Comment 3 2013-04-04 23:17:07 PDT
Comment on attachment 196345 [details] Patch R=me
WebKit Commit Bot
Comment 4 2013-04-04 23:45:14 PDT
Comment on attachment 196345 [details] Patch Clearing flags on attachment: 196345 Committed r147713: <http://trac.webkit.org/changeset/147713>
WebKit Commit Bot
Comment 5 2013-04-04 23:45:16 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.