Summary: | Refine LOG messages in WebSocket related components | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Takeshi Yoshino <tyoshino> | ||||||||
Component: | WebCore JavaScript | Assignee: | Takeshi Yoshino <tyoshino> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Minor | CC: | ap, ricea, tkent, toyoshim, webkit.review.bot, yhirano | ||||||||
Priority: | P3 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Takeshi Yoshino
2013-04-02 23:48:18 PDT
Created attachment 196290 [details]
Patch
Comment on attachment 196290 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=196290&action=review > Source/WebCore/Modules/websockets/WebSocketChannel.cpp:390 > + LOG(Network, "WebSocketChannel %p appendToBuffer Buffer overflow (%lu bytes already in receive buffer and appending %lu bytes)", this, static_cast<unsigned long>(m_buffer.size()), static_cast<unsigned long>(len)); appendToBuffer -> appendToBuffer() for consistency? > Source/WebCore/Modules/websockets/WebSocketChannel.cpp:468 > + LOG(Network, "WebSocketChannel %p startClosingHandshake code=%d m_receivedClosingHandshake=%d", this, m_closing, m_receivedClosingHandshake); startClosingHandshake -> startClosingHandshake() ? Created attachment 196302 [details]
Patch
(In reply to comment #2) Thanks for review. Fixed both. Created attachment 196314 [details]
Patch
(In reply to comment #5) Sorry for last minute fix. Replaced %p in WebSocket.cpp L356 with '%s' as it's printable URL data. Comment on attachment 196314 [details] Patch Clearing flags on attachment: 196314 Committed r147542: <http://trac.webkit.org/changeset/147542> All reviewed patches have been landed. Closing bug. |