Bug 113851

Summary: [GStreamer] Virtual modifier for MediaPlayer::simulateAudioInterruption must go
Product: WebKit Reporter: Xabier Rodríguez Calvar <calvaris>
Component: MediaAssignee: Xabier Rodríguez Calvar <calvaris>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, calvaris, dglazkov, eric.carlson, esprehn+autocc, feature-media-reviews, guijemont, gustavo, jer.noble, menard, mrobinson, ojan.autocc, rego+ews, rniwa, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Xabier Rodríguez Calvar
Reported 2013-04-02 23:35:19 PDT
+++ This bug was initially created as a clone of Bug #91611 +++ We need to support the request-state GstMessage in the MediaPlayerPrivateGStreamer backend so as to play/pause our pipeline upon downstream request. http://gstreamer.freedesktop.org/data/doc/gstreamer/head/gstreamer/html/gstreamer-GstMessage.html#gst-message-new-request-state
Attachments
Patch (2.39 KB, patch)
2013-04-04 02:50 PDT, Xabier Rodríguez Calvar 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Xabier Rodríguez Calvar
Comment 1 2013-04-04 02:50:04 PDT
Created attachment 196461 [details] Patch Removed virtual and added symbol to the filter.
Eric Carlson
Comment 2 2013-04-04 07:52:17 PDT
Comment on attachment 196461 [details] Patch Thanks for the clean-up!
WebKit Review Bot
Comment 3 2013-04-04 08:13:40 PDT
Comment on attachment 196461 [details] Patch Clearing flags on attachment: 196461 Committed r147628: <http://trac.webkit.org/changeset/147628>
WebKit Review Bot
Comment 4 2013-04-04 08:13:44 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.