Bug 113838

Summary: Compositing tests failing after http://trac.webkit.org/changeset/147502
Product: WebKit Reporter: Dean Jackson <dino>
Component: Layout and RenderingAssignee: Max Vujovic <mvujovic>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Attachments
Patch (3.49 KB, patch)
2013-04-03 10:09 PDT, Max Vujovic 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dean Jackson
Comment 1 2013-04-02 17:27:31 PDT
Skipping in https://trac.webkit.org/r147510
Max Vujovic
Comment 2 2013-04-02 21:51:08 PDT
(In reply to comment #1) > Skipping in https://trac.webkit.org/r147510 Thanks Dean! I forgot to update the expectations to contain "(contentsOpaque 1)" due to bug 108656. I'll commit new baselines tomorrow.
Max Vujovic
Comment 3 2013-04-03 10:09:04 PDT
Created attachment 196368 [details] Patch The bug that added (contentsOpaque 1) recently was actually bug 70634. I updated the expectations for these tests in bug 109098 before that change landed and not after. Mac WK2 EWS was borked recently so we didn't see the failures until now.
Dean Jackson
Comment 4 2013-04-03 12:40:18 PDT
Thanks Max!!
Max Vujovic
Comment 5 2013-04-03 12:48:39 PDT
Comment on attachment 196368 [details] Patch No problem. Thanks Dean!
WebKit Review Bot
Comment 6 2013-04-03 12:52:20 PDT
Comment on attachment 196368 [details] Patch Clearing flags on attachment: 196368 Committed r147577: <http://trac.webkit.org/changeset/147577>
WebKit Review Bot
Comment 7 2013-04-03 12:52:23 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.