Bug 113819

Summary: fourthTier: FTL should have the equivalent of a ValueRecovery
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 113623    
Attachments:
Description Flags
the patch mhahnenberg: review+

Filip Pizlo
Reported 2013-04-02 12:21:22 PDT
ValueRecoveries speak of registers. The FTL doesn't speak of registers. Also, the FTL doesn't have to reason about the plethora of places that a value could have been put into; it just needs to know the LLVMValueRef (i.e. LValue). In fact, the FTL really just needs to speak in terms of values-with-formats - essentially a modestly type-refined LLVM value.
Attachments
the patch (10.19 KB, patch)
2013-04-02 12:26 PDT, Filip Pizlo 		mhahnenberg: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2013-04-02 12:26:45 PDT
Created attachment 196209 [details] the patch
Mark Hahnenberg
Comment 2 2013-04-02 12:30:54 PDT
Comment on attachment 196209 [details] the patch r=me
Filip Pizlo
Comment 3 2013-04-02 12:52:35 PDT
Landed in http://trac.webkit.org/changeset/147487
Note You need to log in before you can comment on or make changes to this bug.