Bug 113816

Summary: [BlackBerry] Adjustments to media controls appearance
Product: WebKit Reporter: John Griggs <jgriggs>
Component: MediaAssignee: John Griggs <jgriggs>
Status: RESOLVED FIXED    
Severity: Minor CC: mifenton, rwlbuis, tonikitoo, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Attachments:
Description Flags
Patch
none
Updated Patch with ChangeLog fixes. none

Description John Griggs 2013-04-02 12:03:39 PDT 
Update the media controls for the BlackBerry platform
Comment 1 John Griggs 2013-04-03 12:06:40 PDT 
Created attachment 196385 [details]
Patch
Comment 2 Rob Buis 2013-04-03 12:09:57 PDT 
Comment on attachment 196385 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=196385&action=review

Please fix the ChangeLog.

> Source/WebCore/ChangeLog:3
> +        2013-04-02  John Griggs  <jgriggs@blackberry.com>

Why the double author lines? One is enough.

> Source/WebCore/ChangeLog:8
> +         - upstream some other cosmetic changes to media controls that were not previously upstreamed.

This should be part of your commit message below, not the bug titles.
Comment 3 John Griggs 2013-04-03 12:14:41 PDT 
Created attachment 196387 [details]
Updated Patch with ChangeLog fixes.
Comment 4 Rob Buis 2013-04-03 12:40:12 PDT 
Comment on attachment 196387 [details]
Updated Patch with ChangeLog fixes.

Ok.
Comment 5 WebKit Review Bot 2013-04-03 13:04:12 PDT 
Comment on attachment 196387 [details]
Updated Patch with ChangeLog fixes.

Clearing flags on attachment: 196387

Committed r147578: <http://trac.webkit.org/changeset/147578>
Comment 6 WebKit Review Bot 2013-04-03 13:04:16 PDT 
All reviewed patches have been landed.  Closing bug.