WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
113816
[BlackBerry] Adjustments to media controls appearance
https://bugs.webkit.org/show_bug.cgi?id=113816
Summary
[BlackBerry] Adjustments to media controls appearance
John Griggs
Reported
2013-04-02 12:03:39 PDT
Update the media controls for the BlackBerry platform
Attachments
Patch
(9.58 KB, patch)
2013-04-03 12:06 PDT
,
John Griggs
no flags
Details
Formatted Diff
Diff
Updated Patch with ChangeLog fixes.
(9.57 KB, patch)
2013-04-03 12:14 PDT
,
John Griggs
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
John Griggs
Comment 1
2013-04-03 12:06:40 PDT
Created
attachment 196385
[details]
Patch
Rob Buis
Comment 2
2013-04-03 12:09:57 PDT
Comment on
attachment 196385
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=196385&action=review
Please fix the ChangeLog.
> Source/WebCore/ChangeLog:3 > + 2013-04-02 John Griggs <
jgriggs@blackberry.com
>
Why the double author lines? One is enough.
> Source/WebCore/ChangeLog:8 > + - upstream some other cosmetic changes to media controls that were not previously upstreamed.
This should be part of your commit message below, not the bug titles.
John Griggs
Comment 3
2013-04-03 12:14:41 PDT
Created
attachment 196387
[details]
Updated Patch with ChangeLog fixes.
Rob Buis
Comment 4
2013-04-03 12:40:12 PDT
Comment on
attachment 196387
[details]
Updated Patch with ChangeLog fixes. Ok.
WebKit Review Bot
Comment 5
2013-04-03 13:04:12 PDT
Comment on
attachment 196387
[details]
Updated Patch with ChangeLog fixes. Clearing flags on attachment: 196387 Committed
r147578
: <
http://trac.webkit.org/changeset/147578
>
WebKit Review Bot
Comment 6
2013-04-03 13:04:16 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug