Bug 113797

Summary: [Skia] Enable GPU-accelerated Skia path for FEComposite filter.
Product: WebKit Reporter: Stephen White <senorblanco>
Component: New BugsAssignee: Stephen White <senorblanco>
Status: RESOLVED FIXED    
Severity: Normal CC: dino, junov, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Stephen White 2013-04-02 09:28:39 PDT
[Skia] Enable GPU-accelerated Skia path for FEComposite filter.
Comment 1 Stephen White 2013-04-02 09:31:00 PDT
Created attachment 196163 [details]
Patch
Comment 2 Adrienne Walker 2013-04-02 10:14:03 PDT
Comment on attachment 196163 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=196163&action=review

R=me, with a few nits.

> Source/WebCore/platform/graphics/filters/skia/FECompositeSkia.cpp:82
> +    typedef SkImageFilter INHERITED;

As a drive-by style comment, defining INHERITED looks a little odd to my eyes.

> LayoutTests/platform/chromium-linux/css3/filters/effect-reference-composite-expected.txt:1
> +layer at (0,0) size 800x600

Is there a reason to have a text dump on either of these tests? They seem entirely like pixel tests.
Comment 3 Stephen White 2013-04-02 10:47:43 PDT
Comment on attachment 196163 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=196163&action=review

>> Source/WebCore/platform/graphics/filters/skia/FECompositeSkia.cpp:82
>> +    typedef SkImageFilter INHERITED;
> 
> As a drive-by style comment, defining INHERITED looks a little odd to my eyes.

Sorry, it's a skia-ism.  Removed.

>> LayoutTests/platform/chromium-linux/css3/filters/effect-reference-composite-expected.txt:1
>> +layer at (0,0) size 800x600
> 
> Is there a reason to have a text dump on either of these tests? They seem entirely like pixel tests.

I could be wrong, but I don't think there's a way to get pixel-only results:

default:  pixel, rendertree
dumpAsText(true):  pixel, text
dumpAsText(false):  text
Comment 4 Stephen White 2013-04-02 10:48:12 PDT
Created attachment 196177 [details]
Patch for landing
Comment 5 WebKit Review Bot 2013-04-02 11:21:53 PDT
Comment on attachment 196177 [details]
Patch for landing

Clearing flags on attachment: 196177

Committed r147470: <http://trac.webkit.org/changeset/147470>
Comment 6 WebKit Review Bot 2013-04-02 11:21:56 PDT
All reviewed patches have been landed.  Closing bug.