Summary: | Check whether popups are allowed before creating a new window | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | jochen | ||||
Component: | New Bugs | Assignee: | jochen | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, japhet, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
jochen
2013-04-02 07:47:27 PDT
Created attachment 196139 [details]
Patch
Comment on attachment 196139 [details] Patch Clearing flags on attachment: 196139 Committed r147454: <http://trac.webkit.org/changeset/147454> All reviewed patches have been landed. Closing bug. Comment on attachment 196139 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=196139&action=review > LayoutTests/fast/loader/url-selected-user-gesture.html:10 > + testRunner.dumpCreateView(); This only exists on Chromium test runner. The test fails on all the other bots. (In reply to comment #4) > (From update of attachment 196139 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=196139&action=review > > > LayoutTests/fast/loader/url-selected-user-gesture.html:10 > > + testRunner.dumpCreateView(); > > This only exists on Chromium test runner. The test fails on all the other bots. meh, fixing |