Summary: | Viewport constrained elements should work properly with headers and footers | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Beth Dakin <bdakin> | ||||
Component: | Layout and Rendering | Assignee: | Beth Dakin <bdakin> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | andersca, bdakin, cmarcelo, jamesr, luiz, sam, simon.fraser, thorton, tonikitoo, webkit.review.bot | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Beth Dakin
2013-04-01 21:14:10 PDT
Created attachment 196068 [details]
Patch
Comment on attachment 196068 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=196068&action=review > Source/WebCore/page/scrolling/ScrollingStateScrollingNode.h:112 > + unsigned headerHeight() const { return m_headerHeight; } int return. > Source/WebCore/page/scrolling/ScrollingStateScrollingNode.h:115 > + unsigned footerHeight() const { return m_footerHeight; } Ditto. > Source/WebCore/page/scrolling/ScrollingStateScrollingNode.h:161 > + unsigned m_headerHeight; > + unsigned m_footerHeight; int? > Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h:77 > + unsigned headerHeight() const { return m_headerHeight; } > + unsigned footerHeight() const { return m_footerHeight; } ints > Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.h:98 > + unsigned m_headerHeight; > + unsigned m_footerHeight; ints > Source/WebCore/page/scrolling/mac/ScrollingCoordinatorMac.h:119 > + unsigned headerHeight; > + unsigned footerHeight; ints > LayoutTests/platform/mac-wk2/tiled-drawing/fixed/four-bars-with-header-and-footer.html:5 > + <meta name="apple-mobile-web-app-capable" content="yes"> Remove this. > LayoutTests/platform/mac-wk2/tiled-drawing/fixed/four-bars-with-header-and-footer.html:47 > + <script type="text/javascript" charset="utf-8"> No need for the attributes. Thanks, Simon! I fixed the errors you found. http://trac.webkit.org/changeset/147471 |