| Summary: | Hide non-coordinated scrollbars for Android M26 | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tien-Ren Chen <trchen> | ||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | aelias, eric, esprehn+autocc, jamesr, ojan.autocc, simon.fraser, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Tien-Ren Chen
2013-04-01 18:24:43 PDT
Created attachment 196050 [details]
Patch
Comment on attachment 196050 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=196050&action=review > Source/WebCore/platform/ScrollView.cpp:919 > +#if OS(ANDROID) This is too mysterious. We don't like OS or PLATFORM #ifdefs sprinkled around like this. (In reply to comment #2) > (From update of attachment 196050 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=196050&action=review > > > Source/WebCore/platform/ScrollView.cpp:919 > > +#if OS(ANDROID) > > This is too mysterious. We don't like OS or PLATFORM #ifdefs sprinkled around like this. It only needs to be landed and then reverted immediately, for our branch management workflow. The cherry-pick script we use needs a WebKit SVN revision number. I don't know if there is a simple workaround to that. (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 196050 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=196050&action=review > > > > > Source/WebCore/platform/ScrollView.cpp:919 > > > +#if OS(ANDROID) > > > > This is too mysterious. We don't like OS or PLATFORM #ifdefs sprinkled around like this. > > It only needs to be landed and then reverted immediately, for our branch management workflow. The cherry-pick script we use needs a WebKit SVN revision number. I don't know if there is a simple workaround to that. That seems a bit crazy, but OK. Comment on attachment 196050 [details]
Patch
r+ assuming it's immediately reverted.
Comment on attachment 196050 [details]
Patch
Thanks for humoring our strange tools :)
Comment on attachment 196050 [details] Patch Clearing flags on attachment: 196050 Committed r147389: <http://trac.webkit.org/changeset/147389> All reviewed patches have been landed. Closing bug. Reverted r147389 for reason: Patch specified it should be reverted Committed r147436: <http://trac.webkit.org/changeset/147436> |