Bug 113738

Summary: Hide non-coordinated scrollbars for Android M26
Product: WebKit Reporter: Tien-Ren Chen <trchen>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: aelias, eric, esprehn+autocc, jamesr, ojan.autocc, simon.fraser, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Tien-Ren Chen
Reported 2013-04-01 18:24:43 PDT
Hide non-coordinated scrollbars for Android M26
Attachments
Patch (2.88 KB, patch)
2013-04-01 18:27 PDT, Tien-Ren Chen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tien-Ren Chen
Comment 1 2013-04-01 18:27:32 PDT
Created attachment 196050 [details] Patch
Simon Fraser (smfr)
Comment 2 2013-04-01 18:35:48 PDT
Comment on attachment 196050 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=196050&action=review > Source/WebCore/platform/ScrollView.cpp:919 > +#if OS(ANDROID) This is too mysterious. We don't like OS or PLATFORM #ifdefs sprinkled around like this.
Tien-Ren Chen
Comment 3 2013-04-01 18:44:33 PDT
(In reply to comment #2) > (From update of attachment 196050 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=196050&action=review > > > Source/WebCore/platform/ScrollView.cpp:919 > > +#if OS(ANDROID) > > This is too mysterious. We don't like OS or PLATFORM #ifdefs sprinkled around like this. It only needs to be landed and then reverted immediately, for our branch management workflow. The cherry-pick script we use needs a WebKit SVN revision number. I don't know if there is a simple workaround to that.
Simon Fraser (smfr)
Comment 4 2013-04-01 20:34:29 PDT
(In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 196050 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=196050&action=review > > > > > Source/WebCore/platform/ScrollView.cpp:919 > > > +#if OS(ANDROID) > > > > This is too mysterious. We don't like OS or PLATFORM #ifdefs sprinkled around like this. > > It only needs to be landed and then reverted immediately, for our branch management workflow. The cherry-pick script we use needs a WebKit SVN revision number. I don't know if there is a simple workaround to that. That seems a bit crazy, but OK.
Simon Fraser (smfr)
Comment 5 2013-04-01 20:34:49 PDT
Comment on attachment 196050 [details] Patch r+ assuming it's immediately reverted.
Alexandre Elias
Comment 6 2013-04-01 20:41:27 PDT
Comment on attachment 196050 [details] Patch Thanks for humoring our strange tools :)
WebKit Review Bot
Comment 7 2013-04-01 23:14:45 PDT
Comment on attachment 196050 [details] Patch Clearing flags on attachment: 196050 Committed r147389: <http://trac.webkit.org/changeset/147389>
WebKit Review Bot
Comment 8 2013-04-01 23:14:48 PDT
All reviewed patches have been landed. Closing bug.
Alexandre Elias
Comment 9 2013-04-02 08:23:31 PDT
Reverted r147389 for reason: Patch specified it should be reverted Committed r147436: <http://trac.webkit.org/changeset/147436>
Note You need to log in before you can comment on or make changes to this bug.