Bug 113737

Summary: Make feature_defines.sh work for VS2010
Product: WebKit Reporter: Roger Fong <roger_fong>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, roger_fong, thorton
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
patch
none
patch thorton: review+

Description Roger Fong 2013-04-01 18:15:04 PDT
VS2010 build uses a new FeatureDefines.props file with a different format from the original FeatureDefines.vsprops.

The feature defines string outputted by feature-defines.sh needs to be corrected for this.

Also creating a feature_defines2010.sh because we still need both feature_defines scripts for now.
Comment 1 Roger Fong 2013-04-01 18:15:22 PDT
<rdar://problem/13343147>
Comment 2 Roger Fong 2013-04-01 18:23:22 PDT
Created attachment 196048 [details]
patch
Comment 3 Roger Fong 2013-04-01 19:09:33 PDT
Created attachment 196052 [details]
patch
Comment 4 Tim Horton 2013-04-01 19:11:04 PDT
Comment on attachment 196052 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=196052&action=review

> WebKitLibraries/win/tools/scripts/feature-defines2010.sh:3
> +# Copyright (C) 2010 Apple Inc. All rights reserved.

2013
Comment 5 Roger Fong 2013-04-01 22:41:16 PDT
committed: http://trac.webkit.org/changeset/147375