Bug 113708

Summary: Web Inspector: [Timeline] unify logic for 3 overview modes in Timeline
Product: WebKit Reporter: Andrey Kosyakov <caseq>
Component: Web Inspector (Deprecated)Assignee: Andrey Kosyakov <caseq>
Status: RESOLVED FIXED    
Severity: Normal CC: apavlov, keishi, loislo, pfeldman, pmuellr, vsevik, web-inspector-bugs, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 113705    
Bug Blocks: 113501    
Attachments:
Description Flags
Patch yurys: review+

Description Andrey Kosyakov 2013-04-01 10:04:17 PDT 
Now that the 3 modes implement a common interface, remove all custom logic in overview pane itself and handle them in a consistent manner.
Comment 1 Andrey Kosyakov 2013-04-01 10:09:20 PDT 
Created attachment 195984 [details]
Patch
Comment 2 Yury Semikhatsky 2013-04-02 07:07:52 PDT 
Comment on attachment 195984 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195984&action=review

> Source/WebCore/inspector/front-end/TimelineOverviewPane.js:148
> +        return null;

Why not just throw if the mode is invalid, you would anyway fail on the first attempt to call a method on the controll at line 131?
Comment 3 Pavel Feldman 2013-04-02 07:16:51 PDT 
Comment on attachment 195984 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195984&action=review

> Source/WebCore/inspector/front-end/TimelineOverviewPane.js:410
> +    getWindowTimes: function(windowLeft, windowRight)

windowTimes (since you touch it...)
Comment 4 Andrey Kosyakov 2013-04-02 07:37:25 PDT 
Comment on attachment 195984 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=195984&action=review

>> Source/WebCore/inspector/front-end/TimelineOverviewPane.js:148
>> +        return null;
> 
> Why not just throw if the mode is invalid, you would anyway fail on the first attempt to call a method on the controll at line 131?

Fixed!

>> Source/WebCore/inspector/front-end/TimelineOverviewPane.js:410
>> +    getWindowTimes: function(windowLeft, windowRight)
> 
> windowTimes (since you touch it...)

Fixed as well.
Comment 5 Andrey Kosyakov 2013-04-02 07:43:03 PDT 
Committed r147431: <http://trac.webkit.org/changeset/147431>