Bug 113704

Summary: r147324 broke the world
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Mark Hahnenberg
Reported 2013-04-01 08:47:52 PDT
Build fix is significant enough to warrant a quick review. Thanks for nothing, EWS.
Attachments
Patch (4.24 KB, patch)
2013-04-01 08:54 PDT, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2013-04-01 08:54:26 PDT
Created attachment 195977 [details] Patch
Mark Lam
Comment 2 2013-04-01 08:57:33 PDT
Comment on attachment 195977 [details] Patch LGTM. The changes are superficial.
Mark Hahnenberg
Comment 3 2013-04-01 08:59:21 PDT
Committed r147330: <http://trac.webkit.org/changeset/147330>
Darin Adler
Comment 4 2013-04-01 09:07:28 PDT
Comment on attachment 195977 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195977&action=review > Source/JavaScriptCore/heap/SuperRegion.cpp:33 > +const uint64_t SuperRegion::s_fixedHeapMemoryPoolSize = 4LLU * 1024LLU * static_cast<uint64_t>(MB); I’m not sure the changes to add LLU are portable enough (since they might be bigger or smaller than uint64_t on various platforms), and they probably also are not needed since you’ve casted MB to uint64_t.
Note You need to log in before you can comment on or make changes to this bug.