Summary: | r147324 broke the world | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Hahnenberg <mhahnenberg> | ||||
Component: | JavaScriptCore | Assignee: | Mark Hahnenberg <mhahnenberg> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | ||||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Mark Hahnenberg
2013-04-01 08:47:52 PDT
Created attachment 195977 [details]
Patch
Comment on attachment 195977 [details]
Patch
LGTM. The changes are superficial.
Committed r147330: <http://trac.webkit.org/changeset/147330> Comment on attachment 195977 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195977&action=review > Source/JavaScriptCore/heap/SuperRegion.cpp:33 > +const uint64_t SuperRegion::s_fixedHeapMemoryPoolSize = 4LLU * 1024LLU * static_cast<uint64_t>(MB); I’m not sure the changes to add LLU are portable enough (since they might be bigger or smaller than uint64_t on various platforms), and they probably also are not needed since you’ve casted MB to uint64_t. |