Summary: | [ATK] build fails when accessibility is turned off | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ed Bartosh <bartosh> | ||||||||
Component: | Accessibility | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | g.czajkowski, gyuyoung.kim, k.czech, mifenton, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Ed Bartosh
2013-04-01 04:55:59 PDT
Created attachment 195961 [details]
Patch
Comment on attachment 195961 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=195961&action=review > Source/WebCore/editing/atk/FrameSelectionAtk.cpp:24 > #include "FrameSelection.h" WebKit coding style says that *all implementation files must #include the primary header second, just after "config.h"* > Source/WebCore/editing/atk/FrameSelectionAtk.cpp:-26 > - Do not touch file unrelated to patch. (In reply to comment #2) > Do not touch file unrelated to patch. s/file/line/g Created attachment 196187 [details]
Updated according to reviewer suggestions.
Comment on attachment 196187 [details] Updated according to reviewer suggestions. View in context: https://bugs.webkit.org/attachment.cgi?id=196187&action=review LGTM otherwise. > Source/WebCore/editing/atk/FrameSelectionAtk.cpp:23 > +#if HAVE(ACCESSIBILITY) It would be good if you add a new line below. > Source/WebCore/editing/atk/FrameSelectionAtk.cpp:111 > +#endif // HAVE(ACCESSIBILITY) It would be good if you add a new line above. Created attachment 196403 [details]
Patch
Updated according to review comments.
Comment on attachment 196403 [details] Patch Clearing flags on attachment: 196403 Committed r147615: <http://trac.webkit.org/changeset/147615> All reviewed patches have been landed. Closing bug. |