Bug 113699

Summary: [ATK] build fails when accessibility is turned off
Product: WebKit Reporter: Ed Bartosh <bartosh>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Severity: Normal CC: g.czajkowski, gyuyoung.kim, k.czech, mifenton, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Description Flags
Updated according to reviewer suggestions.
gyuyoung.kim: review+, gyuyoung.kim: commit-queue-
Patch none

Description Ed Bartosh 2013-04-01 04:55:59 PDT
Running build with --minimal while working on #113641 and #113660 triggered this build failure:

Source/WebCore/editing/atk/FrameSelectionAtk.cpp:28:40: fatal error: WebKitAccessibleWrapperAtk.h: No such file or directory
compilation terminated.
[ 80%] Building CXX object Source/WebCore/CMakeFiles/webcore_efl.dir/page/efl/EventHandlerEfl.cpp.o
make[2]: *** [Source/WebCore/CMakeFiles/webcore_efl.dir/editing/atk/FrameSelectionAtk.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [Source/WebCore/CMakeFiles/webcore_efl.dir/all] Error 2
make: *** [all] Error 2

Compilation exited abnormally with code 2 at Mon Apr  1 14:46:55
Comment 1 Ed Bartosh 2013-04-01 05:13:44 PDT
Created attachment 195961 [details]
Comment 2 Gyuyoung Kim 2013-04-01 18:04:42 PDT
Comment on attachment 195961 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=195961&action=review

> Source/WebCore/editing/atk/FrameSelectionAtk.cpp:24
>  #include "FrameSelection.h"

WebKit coding style says that *all implementation files must #include the primary header second, just after "config.h"*

> Source/WebCore/editing/atk/FrameSelectionAtk.cpp:-26
> -

Do not touch file unrelated to patch.
Comment 3 Gyuyoung Kim 2013-04-01 18:05:18 PDT
(In reply to comment #2)

> Do not touch file unrelated to patch.

Comment 4 Ed Bartosh 2013-04-02 11:05:31 PDT
Created attachment 196187 [details]
Updated according to reviewer suggestions.
Comment 5 Gyuyoung Kim 2013-04-02 21:28:27 PDT
Comment on attachment 196187 [details]
Updated according to reviewer suggestions.

View in context: https://bugs.webkit.org/attachment.cgi?id=196187&action=review

LGTM otherwise.

> Source/WebCore/editing/atk/FrameSelectionAtk.cpp:23

It would be good if you add a new line below.

> Source/WebCore/editing/atk/FrameSelectionAtk.cpp:111

It would be good if you add a new line above.
Comment 6 Ed Bartosh 2013-04-03 13:04:49 PDT
Created attachment 196403 [details]

Updated according to review comments.
Comment 7 WebKit Review Bot 2013-04-04 01:37:48 PDT
Comment on attachment 196403 [details]

Clearing flags on attachment: 196403

Committed r147615: <http://trac.webkit.org/changeset/147615>
Comment 8 WebKit Review Bot 2013-04-04 01:37:53 PDT
All reviewed patches have been landed.  Closing bug.