| Summary: | When a line has two size texts, the bigger text's under line which position is under is too far from its bottom. | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yuki Sekiguchi <yuki.sekiguchi> | ||||||||||||||
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||||||||||||
| Status: | UNCONFIRMED --- | ||||||||||||||||
| Severity: | Normal | CC: | ahmad.saleem792, dbates, eric, esprehn+autocc, leviw, mmaxfield, ojan.autocc, webkit.review.bot | ||||||||||||||
| Priority: | P2 | ||||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||
| OS: | Unspecified | ||||||||||||||||
| Attachments: |
|
||||||||||||||||
Created attachment 195956 [details]
Patch
Hi Levi, Could you review this patch? This patch fix the bug which you reviewed at the following commit: http://trac.webkit.org/changeset/146104 Created attachment 278018 [details]
Edge
Created attachment 278019 [details]
Chrome
Created attachment 278020 [details]
Firefox
As you can see from the screenshots I just uploaded, all the browsers vary both the position and thickness of underlines based on font size. This patch (195956) does not apply any more. Comment on attachment 195956 [details]
Patch
We need to make sure that the following content places the two underlines differently with different thicknesses:
<p style="text-decoration: underline; font-size: 90px;">Hello</p>
<p style="text-decoration: underline; font-size: 10px;">Hello</p>
The patch, as its posted, does not appear to do that (although I can't tell for sure because I can no longer apply it)
Created attachment 466501 [details]
WebKit ToT vs Other browsers
Firefox Nightly 115 and Chrome Canary 115 seems to match while WebKit / Safari seems to be different.
|
Created attachment 195955 [details] reproduced html content You need to define ENABLE_CSS3_TEXT, so nightly build cannot reproduce this. In the attached content, the underline of "big p" is far from its bottom.