Bug 113698

Summary: When a line has two size texts, the bigger text's under line which position is under is too far from its bottom.
Product: WebKit Reporter: Yuki Sekiguchi <yuki.sekiguchi>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: UNCONFIRMED    
Severity: Normal CC: ahmad.saleem792, dbates, eric, esprehn+autocc, leviw, mmaxfield, ojan.autocc, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
reproduced html content
none
Patch
mmaxfield: review-
Edge
none
Chrome
none
Firefox
none
WebKit ToT vs Other browsers none

Yuki Sekiguchi
Reported 2013-04-01 04:39:24 PDT
Created attachment 195955 [details] reproduced html content You need to define ENABLE_CSS3_TEXT, so nightly build cannot reproduce this. In the attached content, the underline of "big p" is far from its bottom.
Attachments
reproduced html content (361 bytes, text/html)
2013-04-01 04:39 PDT, Yuki Sekiguchi 		no flags
Details
Patch (15.33 KB, patch)
2013-04-01 04:55 PDT, Yuki Sekiguchi 		mmaxfield: review-
DetailsFormatted DiffDiff
Edge (13.15 KB, image/png)
2016-05-03 13:48 PDT, Myles C. Maxfield 		no flags
Details
Chrome (164.88 KB, image/png)
2016-05-03 13:48 PDT, Myles C. Maxfield 		no flags
Details
Firefox (165.23 KB, image/png)
2016-05-03 13:49 PDT, Myles C. Maxfield 		no flags
Details
WebKit ToT vs Other browsers (258.16 KB, image/png)
2023-05-25 14:18 PDT, Ahmad Saleem 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Yuki Sekiguchi
Comment 1 2013-04-01 04:55:05 PDT
Created attachment 195956 [details] Patch
Yuki Sekiguchi
Comment 2 2013-04-01 17:57:48 PDT
Hi Levi, Could you review this patch? This patch fix the bug which you reviewed at the following commit: http://trac.webkit.org/changeset/146104
Myles C. Maxfield
Comment 3 2016-05-03 13:48:43 PDT
Created attachment 278018 [details] Edge
Myles C. Maxfield
Comment 4 2016-05-03 13:48:55 PDT
Created attachment 278019 [details] Chrome
Myles C. Maxfield
Comment 5 2016-05-03 13:49:07 PDT
Created attachment 278020 [details] Firefox
Myles C. Maxfield
Comment 6 2016-05-03 13:49:50 PDT
As you can see from the screenshots I just uploaded, all the browsers vary both the position and thickness of underlines based on font size.
Myles C. Maxfield
Comment 7 2016-05-03 13:51:43 PDT
This patch (195956) does not apply any more.
Myles C. Maxfield
Comment 8 2016-05-03 13:54:01 PDT
Comment on attachment 195956 [details] Patch We need to make sure that the following content places the two underlines differently with different thicknesses: <p style="text-decoration: underline; font-size: 90px;">Hello</p> <p style="text-decoration: underline; font-size: 10px;">Hello</p> The patch, as its posted, does not appear to do that (although I can't tell for sure because I can no longer apply it)
Ahmad Saleem
Comment 9 2023-05-25 14:18:57 PDT
Created attachment 466501 [details] WebKit ToT vs Other browsers Firefox Nightly 115 and Chrome Canary 115 seems to match while WebKit / Safari seems to be different.
Note You need to log in before you can comment on or make changes to this bug.