Bug 113685

Summary: [EFL][CMAKE] Move MOZ_X11 definition from OptionsCommon to OptionsEfl
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKit EFLAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gyuyoung.kim, kenneth, lucas.de.marchi, rakuco, ryuan.choi, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Carlos Garcia Campos
Reported 2013-04-01 00:35:33 PDT
MOZ_X11 is added unconditionally in OptionsCommon for UNIX platforms, but not all UNIX platforms use X11 for plugins, BlackBerry doesn't. The only port using cmake that uses X11 is EFL and it already has checks for X11, so we can just move the definition to OptionsEfl.
Attachments
Patch (1.76 KB, patch)
2013-04-01 00:37 PDT, Carlos Garcia Campos 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2013-04-01 00:37:33 PDT
Created attachment 195935 [details] Patch
Martin Robinson
Comment 2 2013-04-01 08:03:13 PDT
Comment on attachment 195935 [details] Patch Seems reasonable.
Carlos Garcia Campos
Comment 3 2013-04-01 08:24:01 PDT
Thanks for the review Martin! could someone from EFL confirm this is sane before I land this, please?
Ryuan Choi
Comment 4 2013-04-01 20:31:33 PDT
(In reply to comment #3) > Thanks for the review Martin! could someone from EFL confirm this is sane before I land this, please? I believe that it should be fine for EFL.
Carlos Garcia Campos
Comment 5 2013-04-01 23:36:28 PDT
Comment on attachment 195935 [details] Patch Thanks!
WebKit Review Bot
Comment 6 2013-04-02 00:09:36 PDT
Comment on attachment 195935 [details] Patch Clearing flags on attachment: 195935 Committed r147396: <http://trac.webkit.org/changeset/147396>
WebKit Review Bot
Comment 7 2013-04-02 00:09:41 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.