|Summary:||[EFL][CMAKE] Move MOZ_X11 definition from OptionsCommon to OptionsEfl|
|Product:||WebKit||Reporter:||Carlos Garcia Campos <cgarcia>|
|Component:||WebKit EFL||Assignee:||Nobody <webkit-unassigned>|
|Severity:||Normal||CC:||gyuyoung.kim, kenneth, lucas.de.marchi, rakuco, ryuan.choi, webkit.review.bot|
|Version:||528+ (Nightly build)|
Description Carlos Garcia Campos 2013-04-01 00:35:33 PDT
MOZ_X11 is added unconditionally in OptionsCommon for UNIX platforms, but not all UNIX platforms use X11 for plugins, BlackBerry doesn't. The only port using cmake that uses X11 is EFL and it already has checks for X11, so we can just move the definition to OptionsEfl.
Comment 2 Martin Robinson 2013-04-01 08:03:13 PDT
Comment on attachment 195935 [details] Patch Seems reasonable.
Comment 3 Carlos Garcia Campos 2013-04-01 08:24:01 PDT
Thanks for the review Martin! could someone from EFL confirm this is sane before I land this, please?
Comment 4 Ryuan Choi 2013-04-01 20:31:33 PDT
(In reply to comment #3) > Thanks for the review Martin! could someone from EFL confirm this is sane before I land this, please? I believe that it should be fine for EFL.
Comment 5 Carlos Garcia Campos 2013-04-01 23:36:28 PDT
Comment on attachment 195935 [details] Patch Thanks!
Comment 6 WebKit Review Bot 2013-04-02 00:09:36 PDT
Comment on attachment 195935 [details] Patch Clearing flags on attachment: 195935 Committed r147396: <http://trac.webkit.org/changeset/147396>
Comment 7 WebKit Review Bot 2013-04-02 00:09:41 PDT
All reviewed patches have been landed. Closing bug.