Bug 113681

Summary:

Remove a couple of malloc from ExceptionBase construction

Product:

WebKit

Reporter:

Benjamin Poulain <benjamin>

Component:

New Bugs

Assignee:

Benjamin Poulain <benjamin>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

esprehn+autocc, ojan.autocc, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Benjamin Poulain 2013-03-31 23:56:28 PDT

Remove a couple of malloc from ExceptionBase construction

Comment 1 Benjamin Poulain 2013-04-01 00:04:14 PDT

Created attachment 195931 [details]
Patch

Comment 2 Darin Adler 2013-04-01 01:13:04 PDT

Comment on attachment 195931 [details]
Patch

Looks good. We also need to fix this so we don’t need to use String::number in cases like this; should format the number into a temporary buffer that can then be appended to the string, not a heap-allocated string.

Comment 3 Benjamin Poulain 2013-04-01 12:27:25 PDT

(In reply to comment #2)
> (From update of attachment 195931 [details])
> Looks good. We also need to fix this so we don’t need to use String::number in cases like this; should format the number into a temporary buffer that can then be appended to the string, not a heap-allocated string.

Yep, this have been annoying me for a while but I have not got the time to fix it yet.

Thank you for the review.

Comment 4 WebKit Review Bot 2013-04-01 13:00:03 PDT

Comment on attachment 195931 [details]
Patch

Clearing flags on attachment: 195931

Committed r147353: <http://trac.webkit.org/changeset/147353>

Comment 5 WebKit Review Bot 2013-04-01 13:00:06 PDT

All reviewed patches have been landed.  Closing bug.